Include GraphAPI and GraphAPITestMocks targets using SPM#2592
Merged
Conversation
…lude them with SPM instead of as separate targets
Collaborator
Generated by 🚫 Danger |
scottkicks
approved these changes
Aug 19, 2025
scottkicks
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Excited to see how this impacts!
Just one clarifying change question
| @@ -7,7 +7,7 @@ import XCTest | |||
| final class WatchProjectResponseEnvelope_WatchProjectMutationTests: XCTestCase { | |||
| func test_envelopeFrom() { | |||
| let mock = Mock<GraphAPITestMocks.Mutation>() | |||
| mock.watchProject = Mock<GraphAPITestMocks.WatchProjectPayload>() | |||
Contributor
There was a problem hiding this comment.
Why do we need these changes?
Contributor
Author
There was a problem hiding this comment.
Ah! So it turns out there's a bug with the generator - or maybe with our GraphQL schema. We have two mutations, WatchProjectMutation and UnwatchProjectMutation, both of which return a watchProject object. However, they each return two different types. Every time we re-generate our GraphQL objects, it switches which type it defines, and one of these tests breaks 🤦♀️
The tests aren't terrible useful, so one solution would be to delete them. I'm not sure we can fix the backend issue.
ifosli
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📲 What
GraphAPIandGraphAPITestMockstargets to the project as a local swift package, instead of as individual targets.GraphAPIandGraphAPITestMocksstatically, instead of dynamically🤔 Why
👀 How
I created a beta distribution build to test this - the build builds and runs!