Add a new query to fetch the PLOT-related date in the Manage Pledge flow

[jovaniks]

📲 What

Adds a new GraphQL query called FetchProjectPledgeOverTimeData to fetch PLOT-related project information from the backend.

🤔 Why

The Manage Pledge flow for PLOT-enabled projects requires certain project-level PLOT fields that are currently only available via GraphQL.

Since updating the existing V1 endpoint is not feasible at this time, this new query will allow us to fetch just the necessary PLOT fields while keeping the rest of the flow intact.

This query enables the function fetchProjectPledgeOverTimeData to retrieve the required information when editing PLOT-enabled pledges.

🛠 How

• Introduced a new query: FetchProjectPledgeOverTimeData

query FetchProjectPledgeOverTimeData($projectId: Int!) {
  project(pid: $projectId) {
    __typename
    isPledgeOverTimeAllowed
    pledgeOverTimeCollectionPlanChargeExplanation
    pledgeOverTimeCollectionPlanChargedAsNPayments
    pledgeOverTimeCollectionPlanShortPitch
    pledgeOverTimeMinimumExplanation
  }
}

👀 See

• MBL-2548

⏰ TODO

• Ideally move forward to swift the fetch project from V1 to GraphQL

[amy-at-kickstarter]

LGTM but requesting a small change in nullability!

[amy-at-kickstarter]

It looks like GraphQL defines all of these as optional. These envelope values should be String? instead of String, so then you can get rid of these empty string placeholder values.

[jovaniks]

I initially had them as optional but changed them to non-optional to align with the Project model. No big deal, can revert if needed.

[amy-at-kickstarter]

Mostly I'm always a bit suspicious of passing around empty placeholder strings! I find nil clearer.

[jovaniks]

Great, I'll go ahead and make the change.

[jovaniks]

Done! PLOT-related fields are now nullable both in ProjectPledgeOverTimeDataEnvelope and in the Project model.

[jovaniks]

Follow-up ticket https://kickstarter.atlassian.net/browse/MBL-2578

[jovaniks]

Adds the missing incremental field to ensure we can pass this value through the UpdateBacking mutation.

[amy-at-kickstarter]

Largely LGTM but I have a specific refactoring or follow-up request.

[amy-at-kickstarter]

If I'm understanding correctly, this will fire three requests in a row for PLOT projects: the first V1 request to fetch the project, then a second GraphQL request to fetch the rewards, and a third GraphQL request to fetch the PLOT data. Chaining together requests like this is ultimately going to lead to a much slower user experience, since it's three network round trips.

Since fetchProjectRewards is a GraphQL request already, could you fold the pledgeOverTime fragment into the second request?

I don't want to block this PR on this, so perhaps you can file a follow-up ticket for this issue. I assume PLOT pledges are a minority of pledges, but I do think this is worth fixing.

[jovaniks]

That's a good call!!! I will go for it on Monday in a follow-up ticket!