[MBL-2079] Replace Send Message Text and Icon On PPOProjectCard#2304
Merged
Conversation
scottkicks
requested review from
a team,
amy-at-kickstarter and
jovaniks
and removed request for
a team
amy-at-kickstarter
approved these changes
Feb 26, 2025
amy-at-kickstarter
left a comment
amy-at-kickstarter
left a comment
Contributor
There was a problem hiding this comment.
LGTM, small suggestion for the screenshot tests
Contributor
There was a problem hiding this comment.
Can you make the creator string long enough to truncate for these tests? Looks a little funny now that it's not long enough to truncate.
jovaniks
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📲 What
Replaces “send a message” clickable text with a mail icon to the PPO card UI
🤔 Why
As a backer, I want a more user friendly way to message my creator with a button.
🛠 How
👀 See
note: the icon is bigger than the chevron that it's replacing so you'll notice a slight increase in the size of this section.
♿️ Accessibility
✅ Acceptance criteria