-
-
Notifications
You must be signed in to change notification settings - Fork 274
Add keyed service registration support #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
khellang
merged 4 commits into
khellang:master
from
A-Ebrahimzadeh-dev:feature/keyed-services
Nov 24, 2025
Merged
Add keyed service registration support #260
khellang
merged 4 commits into
khellang:master
from
A-Ebrahimzadeh-dev:feature/keyed-services
Nov 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @A-Ebrahimzadeh-dev! 👋🏻 This looks like a good contribution, thank you! 🙏🏻 Would you be able to add some tests? |
Add tests and fix service key detection issue
Contributor
Author
Hi 👋🏻 Thanks a lot for the feedback! I’ve added the tests as requested. Please let me know if you’d like me to improve or adjust anything 🙏 |
khellang
approved these changes
Nov 24, 2025
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
Closed
This was referenced Dec 14, 2025
This was referenced Dec 24, 2025
This was referenced Jan 1, 2026
This was referenced Jan 25, 2026
github-merge-queue bot
pushed a commit
to DFE-Digital/teaching-record-system
that referenced
this pull request
Jan 29, 2026
Updated [Scrutor](https://github.com/khellang/Scrutor) from 6.1.0 to 7.0.0. <details> <summary>Release notes</summary> _Sourced from [Scrutor's releases](https://github.com/khellang/Scrutor/releases)._ ## 7.0.0 ## What's Changed * Add Sponsors section to README by @khellang in khellang/Scrutor#255 * Update to .NET 10 by @khellang in khellang/Scrutor#265 * Add NuGet packaging and GitHub Packages upload to CI by @khellang in khellang/Scrutor#266 * Use MinVer for versioning by @khellang in khellang/Scrutor#267 * Add support for service key registration by @mokarchi in khellang/Scrutor#262 * Add support for exposing decorated services by @adamjones2 in khellang/Scrutor#261 * Add keyed service registration support by @A-Ebrahimzadeh-dev in khellang/Scrutor#260 ## New Contributors * @mokarchi made their first contribution in khellang/Scrutor#262 * @adamjones2 made their first contribution in khellang/Scrutor#261 * @A-Ebrahimzadeh-dev made their first contribution in khellang/Scrutor#260 **Full Changelog**: khellang/Scrutor@v6.1.0...v7.0.0 Commits viewable in [compare view](khellang/Scrutor@v6.1.0...v7.0.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James Gunn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for registering services with a service key in Scrutor.
Currently, Scrutor does not provide a way to register keyed services.
With this change, developers can specify a key when registering a service via
ServiceDescriptorAttribute.Changes
ServiceDescriptorAttributeto allow an optionalServiceKeyproperty.ServiceKeyif provided.Motivation
Adding keyed services allows more flexible dependency injection scenarios,
such as having multiple implementations of the same interface and selecting them by key at resolution time.
Example