Skip to content

Conversation

@A-Ebrahimzadeh-dev
Copy link
Contributor

Summary

This PR adds support for registering services with a service key in Scrutor.
Currently, Scrutor does not provide a way to register keyed services.
With this change, developers can specify a key when registering a service via ServiceDescriptorAttribute.

Changes

  • Modified ServiceDescriptorAttribute to allow an optional ServiceKey property.
  • Updated registration logic to respect ServiceKey if provided.
  • Preserved backward compatibility for existing code without keys.

Motivation

Adding keyed services allows more flexible dependency injection scenarios,
such as having multiple implementations of the same interface and selecting them by key at resolution time.

Example

[ServiceDescriptor(serviceType: typeof(IMyService), lifetime: ServiceLifetime.Transient, serviceKey: "specificService")]
public class MyService : IMyService { }

@khellang
Copy link
Owner

khellang commented Sep 11, 2025

Hi @A-Ebrahimzadeh-dev! 👋🏻

This looks like a good contribution, thank you! 🙏🏻

Would you be able to add some tests?

@A-Ebrahimzadeh-dev
Copy link
Contributor Author

Hi @A-Ebrahimzadeh-dev! 👋🏻

This looks like a good contribution, thank you! 🙏🏻

Would you be able to add some tests?

Hi 👋🏻 Thanks a lot for the feedback! I’ve added the tests as requested. Please let me know if you’d like me to improve or adjust anything 🙏

@khellang khellang merged commit d622284 into khellang:master Nov 24, 2025
This was referenced Nov 24, 2025
github-merge-queue bot pushed a commit to DFE-Digital/teaching-record-system that referenced this pull request Jan 29, 2026
Updated [Scrutor](https://github.com/khellang/Scrutor) from 6.1.0 to
7.0.0.

<details>
<summary>Release notes</summary>

_Sourced from [Scrutor's
releases](https://github.com/khellang/Scrutor/releases)._

## 7.0.0

## What's Changed
* Add Sponsors section to README by @​khellang in
khellang/Scrutor#255
* Update to .NET 10 by @​khellang in
khellang/Scrutor#265
* Add NuGet packaging and GitHub Packages upload to CI by @​khellang in
khellang/Scrutor#266
* Use MinVer for versioning by @​khellang in
khellang/Scrutor#267
* Add support for service key registration by @​mokarchi in
khellang/Scrutor#262
* Add support for exposing decorated services by @​adamjones2 in
khellang/Scrutor#261
* Add keyed service registration support by @​A-Ebrahimzadeh-dev in
khellang/Scrutor#260

## New Contributors
* @​mokarchi made their first contribution in
khellang/Scrutor#262
* @​adamjones2 made their first contribution in
khellang/Scrutor#261
* @​A-Ebrahimzadeh-dev made their first contribution in
khellang/Scrutor#260

**Full Changelog**:
khellang/Scrutor@v6.1.0...v7.0.0

Commits viewable in [compare
view](khellang/Scrutor@v6.1.0...v7.0.0).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Scrutor&package-manager=nuget&previous-version=6.1.0&new-version=7.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: James Gunn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants