Polishing the window glass effect#82
Merged
khang-nd merged 4 commits intokhang-nd:mainfrom Oct 27, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
Also, should I make those glass stripe effects optional? Because, on second thought, that's a lot of gradients, some low-end and mobile devices might have difficulty rendering those. |
khang-nd
requested changes
Oct 25, 2023
Owner
khang-nd
left a comment
There was a problem hiding this comment.
This is solid work @hohaicongthuan, super impressed 🤯 But as we can notice some performance drawbacks, let's keep these gradients in a utility class (maybe chuck them in the same .glass class) so users can opt-in if they want to experience the glass reflection effect.
Contributor
Author
khang-nd
approved these changes
Oct 27, 2023
Owner
khang-nd
left a comment
There was a problem hiding this comment.
Looks good to me, thanks mate 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add the glass stripes/reflection effect.
It's not an exact replica but I think it's close enough.
I've also put together a small demo here with draggable windows.