Fix summary toggle visibility for treeview and collapse#101
Merged
khang-nd merged 2 commits intokhang-nd:mainfrom Oct 31, 2024
Merged
Fix summary toggle visibility for treeview and collapse#101khang-nd merged 2 commits intokhang-nd:mainfrom
khang-nd merged 2 commits intokhang-nd:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lfuelling
changed the title
khang-nd
reviewed
Oct 30, 2024
Owner
khang-nd
left a comment
khang-nd
left a comment
There was a problem hiding this comment.
Is this on Safari? I don't see it in either Chrome or Firefox. Changes look good to me though.
Contributor
Author
|
Yes, it's happening on Safari. If you want I can wrap all the changes in |
Owner
|
All good, doesn't seem like there's any regression for other browsers. Merging in. Thanks for picking this up :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
this PR fixes the summary toggle visibility for the collapse and treeview elements, and the line-height calculation for the treeview toggle (to center the symbol).
Before (duplicated indicators, off-center treeview toggle)
After
Thanks