e2e: add HTTPS listener test for XListenerSet#13502
Open
devc007 wants to merge 2 commits intokgateway-dev:mainfrom
Open
e2e: add HTTPS listener test for XListenerSet#13502devc007 wants to merge 2 commits intokgateway-dev:mainfrom
devc007 wants to merge 2 commits intokgateway-dev:mainfrom
Conversation
gateway-bot
added
kind/feature
Add end-to-end test to verify HTTPS listener functionality on XListenerSet resources, providing sanity checks for regressions in TLS behavior. The test validates: - HTTPS listener attachment to XListenerSet - TLS certificate reference resolution (including cross-namespace with ReferenceGrant) - TLS termination at the gateway - End-to-end HTTPS connectivity Test creates: - TLS secret with self-signed certificate - XListenerSet with HTTPS listener on port 8443 - HTTPRoute targeting the XListenerSet - ReferenceGrant for cross-namespace secret access Fixes kgateway-dev#12968 Signed-off-by: devesh <[email protected]>
devc007
force-pushed
the
e2eTestForHTTPListener
branch
from
2897df1 to
eb972a9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an end-to-end test case to validate HTTPS listener behavior on XListenerSet, covering TLS cert reference resolution (including cross-namespace via ReferenceGrant) and end-to-end HTTPS connectivity to a backend through the Gateway.
Changes:
- Register a new
TestHTTPSListenerSettest case and supporting constants/objects. - Add a self-signed TLS
Secretmanifest used by the HTTPS listener. - Add an
XListenerSet+HTTPRoute+ReferenceGrantmanifest to exercise cross-namespace TLS secret reference and HTTPS routing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/e2e/features/listenerset/types.go | Adds manifest paths, HTTPS port constant, and registers the new HTTPS test case. |
| test/e2e/features/listenerset/suite.go | Implements TestHTTPSListenerSet with status assertions and HTTPS curl validation. |
| test/e2e/features/listenerset/testdata/tls-secret.yaml | Adds a TLS secret used by the HTTPS listener. |
| test/e2e/features/listenerset/testdata/https-listenerset.yaml | Adds XListenerSet HTTPS listener + HTTPRoute and ReferenceGrant to allow cross-namespace secret reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
….AssertionsT(s.T()) Signed-off-by: devesh <[email protected]>
devc007
force-pushed
the
e2eTestForHTTPListener
branch
from
7242340 to
a1d60d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add end-to-end test to verify HTTPS listener functionality on XListenerSet resources, providing sanity checks for regressions in TLS behavior.
The test validates:
Test creates:
Fixes #12968
Change Type
Changelog