test: add e2e test for GatewayParameters update triggering reconciliation#13485
Open
chandler-solo wants to merge 3 commits intokgateway-dev:mainfrom
Open
test: add e2e test for GatewayParameters update triggering reconciliation#13485chandler-solo wants to merge 3 commits intokgateway-dev:mainfrom
chandler-solo wants to merge 3 commits intokgateway-dev:mainfrom
Conversation
We have to reconcile the data plane if gateway parameters change (GatewayParameters re: envoy, AgentgatewayParameters re: agentgateway), and we had duplicate code but were using only one of the two routines. I think this deduplication of gateway parameter event handling logic is better than using both routines. Signed-off-by: David L. Chandler <[email protected]>
gateway-bot
added
kind/cleanup
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deduplicates the Gateway-parameter-driven event handling in the Gateway controller so Gateways reconcile when either GatewayParameters (envoy) or AgentgatewayParameters (agentgateway) change, and adds e2e coverage to ensure both parameter types trigger reconciliation.
Changes:
- Consolidate duplicate parameter event handlers into a single
gatewayParamEventHandlershared by both parameter clients. - Add an e2e test ensuring
GatewayParametersupdates propagate to the rendered Deployment (proving reconciliation). - Add a new agentgateway e2e suite and manifest ensuring
AgentgatewayParametersupdates trigger reconciliation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/tests/agent_gateway_tests.go | Registers the new agentgateway “Deployer” e2e suite. |
| test/e2e/features/deployer/suite.go | Adds an e2e test verifying GatewayParameters updates trigger reconciliation (Deployment template annotation update). |
| test/e2e/features/agentgateway/deployer/types.go | Defines manifest path and object metadata for the new agentgateway deployer suite. |
| test/e2e/features/agentgateway/deployer/testdata/agentgateway-with-parameters.yaml | New test manifest wiring a Gateway to AgentgatewayParameters. |
| test/e2e/features/agentgateway/deployer/suite.go | New e2e suite verifying AgentgatewayParameters updates reconcile and update the Deployment. |
| pkg/kgateway/controller/gw_controller.go | Deduplicates parameter event handling by using one shared handler for both parameter types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andy-fong
approved these changes
Feb 10, 2026
…ntrollerextension
Signed-off-by: David L. Chandler <[email protected]>
chandler-solo
changed the title
Contributor
Author
|
This PR boils down to a single new test case after agengateway moved repos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have to reconcile the data plane if gateway parameters (GatewayParameters) change. Let's add a test.
Change Type
/kind cleanup
Changelog
Additional Notes