Skip to content

Initial codeowners #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jenshu merged 6 commits into from
Dec 16, 2025
Merged

Initial codeowners #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2775c4c
initial codeowners
npolshakova Dec 3, 2025
cb94cc5
feedback
npolshakova Dec 15, 2025
f37b364
Merge branch 'main' into initial-codeowner-groups
jenshu Dec 16, 2025
30f1858
Apply suggestion from @jenshu
jenshu Dec 16, 2025
0b42500
Apply suggestion from @jenshu
jenshu Dec 16, 2025
f99e8ff
Apply suggestion
jenshu Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions CONTRIBUTOR_LADDER.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ To apply to become a member of the kgateway-dev organization on GitHub, please o
1. Use the [membership request template](.github/PULL_REQUEST_TEMPLATE/apply_to_be_a_member.md). This template is linked from the default template when you open a PR, or you can paste this URL in your browser `https://github.com/kgateway-dev/community/compare/main...<my-fork>:<my-branch>?quick_pull=1&title=Request%20org%20membership%20for%20<user>&labels=membership&template=apply_to_be_a_member.md`, replacing:
- `<my-fork>:<my-branch>` with your fork/branch name, and
- `<user>` with your GitHub username
1. Add your GitHub username to the list of members (under `orgs.kgateway-dev.members` and `orgs.kgateway-dev.teams.org-members.members`) in our [organization file](./org.yaml). Please add your name in the correct alphabetical order to maintain a tidy organization file.
2. Add your GitHub username to the list of members (under `orgs.kgateway-dev.members` and `orgs.kgateway-dev.teams.org-members.members`) in our [organization file](./org.yaml). Please add your name in the correct alphabetical order to maintain a tidy organization file.

### Maintainer

Expand All @@ -75,11 +75,20 @@ A Maintainer must meet the responsibilities and requirements of an Organization

Any current Maintainer may nominate a current Organization Member to become a new Maintainer in one or more repositories, by opening a PR in the community repository using the [maintainer nomination template](.github/PULL_REQUEST_TEMPLATE/nominate_a_maintainer.md). The following requirements must be met before the PR is merged:
1. Each item in the template checklist must be satisfied.
1. At least 2 current Maintainers from each relevant repository must approve the PR.
1. There must be no objections from other maintainers. This can be achieved by either of the following, whichever occurs first:
2. At least 2 current Maintainers from each relevant repository must approve the PR.
3. There must be no objections from other maintainers. This can be achieved by either of the following, whichever occurs first:
* Leaving the PR open for one week with no objections
* Asking at the weekly community meeting whether there are any objections

### Becoming a CODEOWNER

You must already be a Maintainer of kgateway to become a CODEOWNER.

1. Review at least 5 PRs and author 5 PRs in the repository under the specific CODEOWNERS group
2. Get nominated by an existing CODEOWNER of that group and update the org.yaml and get a +1 from another CODEOWNER
Copy link
Contributor

@jenshu jenshu Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we get nominated? would it be a PR using a specific template (similar to org membership and maintainer nomination)?

(also, if we want to give this more thought, i'm good with ripping out the updates to this file and handling it in a follow-up PR)

Copy link
Contributor Author

@npolshakova npolshakova Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a template, especially if we eventually want to move to Prow. That's extra overhead and process for something that we know we want to be able to change.

I think the person nominated just needs to open a PR with the change to add the new codeowner, and we need a +1 comment.


Additional specific CODEOWNER requirements can be decided by the CODEOWNER group and the community as needed.

## Inactivity

It is important for contributors to be and stay active to set an example and show commitment to the project. Inactivity is harmful to the project as it may lead to unexpected delays, contributor attrition, and a lost of trust in the project.
Expand Down
20 changes: 20 additions & 0 deletions org.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,26 @@ orgs:
privacy: closed
repos:
kgateway.dev: maintain
kgateway-api-owners:
description: Maintainers of the kgateway envoy API
maintainers:
- howardjohn
- jenshu
- lgadban
- shashankram
- timflannagan
- yuval-k
privacy: closed
agentgateway-api-owners:
description: Maintainers of the kgateway agentgateway API
maintainers:
- howardjohn
- jenshu
- lgadban
- npolshakova
- shashankram
- yuval-k
privacy: closed
eligible-voters:
description: ""
maintainers:
Expand Down