Remove JSON polyfill since Prisma now supports the Json scalar for SQLite #9541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
approved these changes
Mar 11, 2025
dcousens
approved these changes
Mar 11, 2025
|
Needs prisma/prisma#26571 |
emmatown
force-pushed
the
remove-jsonFieldTypePolyfilledForSQLite
branch
2 times, most recently
from
150b7d5 to
1425c9c
Compare
emmatown
force-pushed
the
remove-jsonFieldTypePolyfilledForSQLite
branch
2 times, most recently
from
cb84c37 to
b2256a1
Compare
…on scalar for SQLite
dcousens
force-pushed
the
remove-jsonFieldTypePolyfilledForSQLite
branch
3 times, most recently
from
8da59c0 to
2576403
Compare
dcousens
changed the title
dcousens
force-pushed
the
remove-jsonFieldTypePolyfilledForSQLite
branch
2 times, most recently
from
88ec578 to
7ffdd1d
Compare
dcousens
force-pushed
the
remove-jsonFieldTypePolyfilledForSQLite
branch
from
7ffdd1d to
79f88cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the JSON polyfill for SQLite and moves to Prisma's native support for the
Jsonscalar type universally.Unfortunately, as a result of prisma/prisma#26571 we can't rely on Prisma to support default values for SQLite for now.
However, rather than continue the string-based polyfill only for native
defaultValues, we are happy to defer that functionality upstream while maintainingdefaultValuesupport through Keystone (not Prisma).