Skip to content

Conversation

@benderham
Copy link
Contributor

Updates the Main and Footer Navigation to include an external link to the new Keystone Enterprise page on the Thinkmill website.

Also updates the LinkItem to accept a rel and target.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

import Link from 'next/link'
import { type HTMLAttributes } from 'react'
import Link from 'next/link';
import { type HTMLAttributes } from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the formatting rule is not to use semi

@benderham benderham force-pushed the keystone-enterprise-link branch from 8f2eb55 to b88370d Compare September 3, 2024 02:16
@benderham benderham force-pushed the keystone-enterprise-link branch from b88370d to 518b577 Compare September 3, 2024 02:42
import { Socials } from './Socials'

function List (props: HTMLAttributes<HTMLElement>) {
function List(props: HTMLAttributes<HTMLElement>) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function List(props: HTMLAttributes<HTMLElement>) {
function List (props: HTMLAttributes<HTMLElement>) {

}

export function Footer () {
export function Footer() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export function Footer() {
export function Footer () {

@dcousens dcousens merged commit 7808e7d into main Sep 3, 2024
@dcousens dcousens deleted the keystone-enterprise-link branch September 3, 2024 03:08
relusion added a commit to relusion/keystone that referenced this pull request Sep 8, 2024
- Remove unused code and imports in backend files
- Add bootstrap v5.3.3 as a frontend dependency
- Update package-lock.json and package.json
- Update App.js to import bootstrap CSS
- Improve loading state in App.js
- Add error handling and fetch posts functionality in App.js
- Add addNewPost functionality in App.js
- Update UI in App.js to display user information and posts

Related to keystonejs#9322, keystonejs#9320, keystonejs#9262
@dcousens dcousens mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants