Skip to content

Conversation

@dcousens
Copy link
Member

@dcousens dcousens commented Aug 29, 2024

Followup to #9275, fixes #9313

This really highlights that we need to put this package under test

@keystonejs keystonejs deleted a comment from codesandbox-ci bot Aug 29, 2024
@dcousens dcousens requested a review from unrevised6419 August 29, 2024 10:50
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4d274c3:

Sandbox Source
@keystone-6/sandbox Configuration

@unrevised6419
Copy link
Member

unrevised6419 commented Aug 29, 2024

@dcousens an idea

#9315

PS: Even better would be to remove the dependency install step and let the user install it themselves. 🙈

@dcousens
Copy link
Member Author

PS: Even better would be to remove the dependency install step and let the user install it themselves. 🙈

I honestly never use these workflows, what are user expectations of this in 2024?

@dcousens dcousens merged commit 616907e into main Aug 30, 2024
@dcousens dcousens deleted the patch-cka branch August 30, 2024 02:14
@dcousens dcousens mentioned this pull request Aug 30, 2024
@unrevised6419
Copy link
Member

unrevised6419 commented Sep 3, 2024

@dcousens

🟩 Runs npm install
🟨 Allows to choose
🟥 Does not run npm install

  • 🟩 Nuxt.js
  • 🟩 Next.js
  • 🟩 Strapi CMS
  • 🟩 Gatsby
  • 🟩 Payload CMS
  • 🟩 Angular
  • 🟩 Nest.js
  • 🟨 Remix
  • 🟨 Astro
  • 🟥 Vite
  • 🟥 Vue.js

@dcousens dcousens mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create-keystone-app ENOENT no such file or directory schema.graphql

3 participants