-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix Astro and Remix examples not building #9247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
188b1b6
287b59f
d70532a
d9b47a2
ac3c48d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| node_modules | ||
| .astro/ | ||
| # Keep environment variables out of version control | ||
| .env |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,22 @@ | ||
| import { defineConfig } from 'astro/config' | ||
| import node from '@astrojs/node' | ||
|
|
||
| // https://astro.build/config | ||
| export default defineConfig({ | ||
| output: 'server', | ||
| adapter: node({ | ||
| mode: 'standalone', | ||
| }), | ||
|
|
||
| // WARNING: this is only needed for our monorepo examples, dont do this | ||
| vite: { | ||
| ssr: { | ||
| external: ['@keystone-6/core/context', '@keystone-6/core', '@keystone-6/core/fields'], | ||
| external: [ | ||
| '@keystone-6/core', | ||
| '@keystone-6/core/context', | ||
| '@keystone-6/core/fields', | ||
| 'myprisma' | ||
| ], | ||
| }, | ||
| }, | ||
| }) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,8 +7,9 @@ | |
|
|
||
| import { config } from '@keystone-6/core' | ||
| import { lists } from './src/keystone/schema' | ||
| import type { TypeInfo } from '.keystone/types' | ||
|
|
||
| export default config({ | ||
| export default config<TypeInfo>({ | ||
| db: { | ||
| // we're using sqlite for the fastest startup experience | ||
| // for more information on what database might be appropriate for you | ||
|
|
@@ -18,7 +19,7 @@ export default config({ | |
|
|
||
| // WARNING: this is only needed for our monorepo examples, dont do this | ||
| // we use using myprisma, not .myprisma, because vite | ||
| prismaClientPath: 'node_modules/myprisma/client', | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It appears that the nested nature of |
||
| prismaClientPath: 'node_modules/myprisma', | ||
| }, | ||
| server: { | ||
| // We're using a custom port for this example so Astro and Keystone can run at the same time | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ datasource sqlite { | |
|
|
||
| generator client { | ||
| provider = "prisma-client-js" | ||
| output = "node_modules/.myprisma/client" | ||
| output = "node_modules/myprisma" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Incompatible here too |
||
| } | ||
|
|
||
| model Post { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An
adapteris required foroutput: 'server', I suspect this was missing initially when added in #8471, or maybe the defaults changed?