-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove deprecated hooks #9204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated hooks #9204
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2676f4e:
|
|
I'll be merging #9166 ASAP, which should help with this pull request, fwiw |
73b2403 to
e2f6ad3
Compare
e2f6ad3 to
f5e3425
Compare
|
@dcousens I am done with this, are you able to take a look and help resolve single type error in lint and documentation. |
|
I have created documentation in separate PR #9231 |
c4d18a2 to
3861fd2
Compare
3861fd2 to
38b2741
Compare
38b2741 to
7a54a00
Compare
9cbda81 to
2676f4e
Compare
|
@dcousens changing base on this to cleanup from deprecated hooks. This has nothing to do with the nextjs upgrade and can be merged sooner for next major release. |
ee3fcc7 to
248fae3
Compare
|
let me know if you have any plan with this or waiting for something. I am unable to fix the typing error if you are waiting for that. |
|
I plan to merge this very soon |
|
I'll happily rebase this soon, should be straight forward - prioritizing the DS upgrade landing for now |
7ff0241 to
fcb03ee
Compare
fcb03ee to
a80a8b5
Compare
|
@dcousens I see that you have already rebased this. You will have to help with the type issue in linting, it is something I am unable to find solution to. |
a80a8b5 to
1a54a55
Compare
|
@emmatown I fixed structure field. Please check linting for select field. |
151347a to
ed57d18
Compare
|
@emmatown there is no point of the PR if you want to keep the top level hooks. |
|
if you are going to keep top level hooks, revert/update #9231 |
|
@gautamsi this removes the deprecated Unpacking the object is often the preferred approach beyond any level of complexity, so I think #9231 stays completely relevant? |
40bfac1 to
c3c565d
Compare
[Replying to myself] we did actually talk about this at length, but opted to keep things aligned with the approach in Maybe in the future a better pattern will emerge where we only retain the unpacked type variants in the unresolved configuration, and some convenience function (like |
This replaces all the hooks from original combined form with the granular one inline with #9056 #9057 #8826
this cleans up the code and is breaking changes.