Increase verbosity of omit tests
#9055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
commented
Mar 6, 2024
| }()), | ||
| }, | ||
| defaultIsFilterable: undefined, | ||
| defaultIsOrderable: undefined, |
There was a problem hiding this comment.
This code doesn't need to be testing defaults, we can do that elsewhere
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 91ef98c:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modifying code near to the
omitfunctionality, I quickly found myself wanting amount of detail as to when and where the tests were failing.Unlike
tapeand other testing suites,jestonly really offers you insight into your tests from thetest(description, () => ..., which you often might group a number ofexpects statements within. This isn't helpful when the tests are verifying a number of expectations at the same time.This pull request changes that so we many
tests, with 1 expectation each. This pattern is actually a huge performance win too, and I'll be using in my next pull request for hooks.