Fixes #8046 regression which prevented other command line arguments from being used #8455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 5, 2023 10:56
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 72aaaba:
|
dcousens
approved these changes
Apr 5, 2023
dcousens
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our recent changes in #8046 added some extra CLI flags, including a new feature that would throw (exit the process early) if any unsupported flags were passed to the CLI.
Unfortunately this broken expected behaviour for anyone using
process.argvfor other purposes in their code.For example, if a user was using something like
--seed-dataas a flag for theironConnectfunction.No one has reported this bug to date, which is good insofar as the blast radius of that breaking change, but, we'll nonetheless revert the change for now to the previous behaviour.