Remove keystone dev --reset-db
#8302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 93f78fc:
|
borisno2
reviewed
Feb 13, 2023
packages/core/src/scripts/cli.ts
Outdated
| return telemetry(cwd, argv[1]); | ||
| } else { | ||
| return commands[command](cwd); | ||
| return prisma(cwd, argv.slice(1), defaultFlags(flags, { frozen: false }).frozen); |
Member
There was a problem hiding this comment.
The default flags function doesn't work fore when you want to pass through a Prisma flag - for example --force-reset
dcousens
force-pushed
the
no-reset-db
branch
from
c2edaa4 to
d572865
Compare
dcousens
force-pushed
the
no-reset-db
branch
from
e690da7 to
f7f6e18
Compare
dcousens
force-pushed
the
no-reset-db
branch
from
710d0c0 to
7d7460a
Compare
dcousens
force-pushed
the
no-reset-db
branch
from
355692d to
310007d
Compare
dcousens
force-pushed
the
no-reset-db
branch
from
310007d to
93f78fc
Compare
borisno2
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes
--reset-db.This command was dangerous at the best of times and frustrating almost every other time you accidentally used it from your shell history.
Resetting your database in this way is not a typical way to work with a local development database.
We recommend using
keystone prisma db push --force-resetfor the limited number of occasions that you need this.This pull request is part of the work from #8046 which cements the idea that
keystone devis about a workflow, and not about kicking off specific actions.(review and merge #8046 before this pull request is rebased)