Skip to content

fix negative max_new_tokens bug #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keyboardAnt merged 1 commit into from
Nov 27, 2024
Merged

fix negative max_new_tokens bug #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/transformers/generation/candidate_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,8 +709,6 @@ def __init__(
# Track sequence lengths and previous assistant IDs
self._prev_target_seq_len: int = 0
self._prev_assistant_ids: Optional[torch.LongTensor] = None
# generation max length according to the assistant vocabulary
self.assistant_generation_max_length = -1

def get_candidates(self, input_ids: torch.LongTensor) -> Tuple[torch.LongTensor, Optional[torch.FloatTensor]]:
"""
Expand All @@ -719,14 +717,7 @@ def get_candidates(self, input_ids: torch.LongTensor) -> Tuple[torch.LongTensor,
input_ids = input_ids.to(self.assistant_model.device)
target_input_ids = input_ids.clone()
assistant_input_ids = self._prepare_assistant_input_ids(target_input_ids)
if self.assistant_generation_max_length == -1:
self.assistant_generation_max_length = self.generation_config.max_length - input_ids.shape[1] + assistant_input_ids.shape[1]

# Standard generation steps
target_generation_max_length = self.generation_config.max_length
self.generation_config.max_length = self.assistant_generation_max_length
min_new_tokens, max_new_tokens = self._calculate_new_tokens(assistant_input_ids)
self.generation_config.max_length = target_generation_max_length
min_new_tokens, max_new_tokens = self._calculate_new_tokens(target_input_ids)

if max_new_tokens == 0:
return input_ids, None
Expand Down