Long Indicator step + 2 minor fixes#11
Open
SmileHub wants to merge 7 commits intokevalpatel2106:masterfrom
Open
Long Indicator step + 2 minor fixes#11SmileHub wants to merge 7 commits intokevalpatel2106:masterfrom
SmileHub wants to merge 7 commits intokevalpatel2106:masterfrom
Conversation
Customizable long indicator step to allow bigger flexibility \ use cases.
Customizable long indicator step to allow bigger flexibility \ use cases.
A long indicator step fully works. Also a fix for a "max value" display.
mHorizontalScrollView isn't fully initialized at first to accept smoothScrollView. So there was a 400ms delay for each selectValue(). The fix i made will selectValue() instantly without annoying delay and in cases when it fails to do that - it will loop 3 attemps with 100ms delay each trying to set (which should be enougth time for the mHorizontalScrollView to initialize (kinda a fallback to old functionality but with attempts to scrool as soon as possible).
Owner
|
@SmileHub Thanks for generating the PR. 👍 I will review it and let you know if I have any questions.🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posibility to define a long indicator step (for example setting to 1 will display all values).
Minor bug fixes:
Extra added:
*padding to a ruler beggining and ending of getIndicatorIntervalWidth() size to both sides for some space in case we will be drawing a text (in future spaces should be dynamically calculated if bigger needs rise up).
*methods for manipulating long interval step: getLongIndicatorStep() and setLongIndicatorStep(final int step)