Skip to content

fix(no-code-editor): preserve cron quotes across edits#1060

Merged
elevatebart merged 4 commits intokestra-io:masterfrom
Ashutoshbind15:fix/14052-cron-quotes-yaml-editor
Feb 5, 2026
Merged

fix(no-code-editor): preserve cron quotes across edits#1060
elevatebart merged 4 commits intokestra-io:masterfrom
Ashutoshbind15:fix/14052-cron-quotes-yaml-editor

Conversation

@Ashutoshbind15
Copy link
Copy Markdown
Contributor

@Ashutoshbind15 Ashutoshbind15 commented Jan 13, 2026

Fixes kestra-io/kestra#14052

Summary of changes:

  • Add a util function to post-process the generated yaml string and add quotations to the cron expressions, when not present
  • Add the needed tests

Tests and Build Info:

  • Tests pass for both ui-libs and the main repo
  • npm run build passes for both (after using the locally built ui-libs as dependency)
  • Lints show no errors on the changes proposed
screenrecording-2026-01-13_21-51-32.mp4

@github-project-automation github-project-automation Bot moved this to To review in Pull Requests Jan 13, 2026
@MilosPaunovic MilosPaunovic added area/frontend Needs frontend code changes kind/external Pull requests raised by community contributors labels Jan 14, 2026
Copy link
Copy Markdown
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's a lot of tests for a simple feature I prefer too much tests than less.

A few nitipcks but overall Good waork.

Thank you !

Comment thread src/utils/FlowYamlUtils.test.ts
Comment thread src/utils/FlowYamlUtils.test.ts
Comment thread src/utils/FlowYamlUtils.test.ts Outdated
@Ashutoshbind15 Ashutoshbind15 force-pushed the fix/14052-cron-quotes-yaml-editor branch from 4f191c6 to 9709ace Compare January 14, 2026 10:20
@Ashutoshbind15
Copy link
Copy Markdown
Contributor Author

Have resolved the review comments @elevatebart, you may re-review/merge as needed.

Thank you!

@elevatebart elevatebart merged commit f291294 into kestra-io:master Feb 5, 2026
@github-project-automation github-project-automation Bot moved this from To review to Done in Pull Requests Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend Needs frontend code changes kind/external Pull requests raised by community contributors

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[No-code editor] Cron quotes disappear in YAML editor while typing

3 participants