fix(no-code-editor): preserve cron quotes across edits#1060
Merged
elevatebart merged 4 commits intokestra-io:masterfrom Feb 5, 2026
Merged
Conversation
elevatebart
approved these changes
Jan 14, 2026
Contributor
elevatebart
left a comment
There was a problem hiding this comment.
Even though it's a lot of tests for a simple feature I prefer too much tests than less.
A few nitipcks but overall Good waork.
Thank you !
4f191c6 to
9709ace
Compare
Contributor
Author
|
Have resolved the review comments @elevatebart, you may re-review/merge as needed. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes kestra-io/kestra#14052
Summary of changes:
Tests and Build Info:
npm run buildpasses for both (after using the locally built ui-libs as dependency)screenrecording-2026-01-13_21-51-32.mp4