Fix migration when SSH server settings exist #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaswal
force-pushed
the
fix-ssh-migrate
branch
from
59ea539 to
f2f539b
Compare
troglobit
reviewed
Apr 10, 2025
Comment on lines
+6
to
+10
| jq ' | ||
| if has("infix-services:ssh") then | ||
| . | ||
| else | ||
| .["infix-services:ssh"] = { |
Contributor
There was a problem hiding this comment.
Sorry for being such a bother, but what happens when a user does:
configure
no ssh
leave
Followed by a reboot? Doesn't this re-enable ssh on port 22 then?
Contributor
There was a problem hiding this comment.
Maybe we should have a discussion with @jovatn about this, first thing tomorrow?
Contributor
Author
There was a problem hiding this comment.
Sorry for being such a bother, but what happens when a user does:
configure
no ssh
leave
Followed by a reboot? Doesn't this re-enable ssh on port 22 then?
Not if the version is stepped up, this, this is what we discussed earlier.
troglobit
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #1015
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: