Skip to content

Conversation

@mattiaswal
Copy link
Contributor

@mattiaswal mattiaswal commented Apr 1, 2025

Changed image type from RAW to qcow2

Also:

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@mattiaswal mattiaswal marked this pull request as draft April 1, 2025 11:15
@mattiaswal mattiaswal force-pushed the fix-images branch 2 times, most recently from baa8377 to 7084a18 Compare April 6, 2025 18:37
@mattiaswal mattiaswal marked this pull request as ready for review April 6, 2025 18:52
@mattiaswal mattiaswal requested review from Copilot and troglobit April 6, 2025 18:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 14 changed files in this pull request and generated 1 comment.

Files not reviewed (13)
  • board/common/mkdisk.sh: Language not supported
  • board/common/post-image.sh: Language not supported
  • board/common/qemu/qemu.sh: Language not supported
  • board/common/rootfs/usr/libexec/infix/init.d/30-cfg-migrate: Language not supported
  • test/env: Language not supported
  • test/qeneth: Language not supported
  • test/templates/inc/infix-disk.mustache: Language not supported
  • test/templates/inc/infix-usb.mustache: Language not supported
  • test/templates/infix-bios-x86_64.mustache: Language not supported
  • test/templates/infix-kernel-x86_64.mustache: Language not supported
  • test/templates/infix-x86_64.mustache: Language not supported
  • test/test.mk: Language not supported
  • test/virt/quad/topology.dot.in: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/release.yml:149

  • The checksum generation block uses '*.qcow2' which might not detect files if they are stored in a subdirectory (e.g. 'output/images/') as defined in the artifact upload step. Ensure the file path is consistent throughout the workflow.
if ls *.qcow2 &>/dev/null; then

@mattiaswal mattiaswal requested a review from wkz April 6, 2025 19:00
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :shipit:

@mattiaswal mattiaswal merged commit 3d86ecd into main Apr 7, 2025
5 checks passed
@mattiaswal mattiaswal deleted the fix-images branch April 7, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong target for symlink in release package

3 participants