Only allow deserialization of KerasSaveables by module and name.
#21429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21429 +/- ##
==========================================
- Coverage 82.72% 82.72% -0.01%
==========================================
Files 565 565
Lines 55222 55245 +23
Branches 8609 8612 +3
==========================================
+ Hits 45683 45700 +17
- Misses 7428 7433 +5
- Partials 2111 2112 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Arbitrary functions and classes are not allowed. - Made `Operation` extend `KerasSaveable`, this required moving imports to avoid circular imports - `Layer` no longer need to extend `KerasSaveable` directly - Made feature space `Cross` and `Feature` extend `KerasSaveable` - Also dissallow public function `enable_unsafe_deserialization`
hertschuh
force-pushed
the
serialization_fix
branch
from
fdf490e to
c69516b
Compare
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Mohamed-Ashraf273
pushed a commit
to Mohamed-Ashraf273/keras
that referenced
this pull request
Jul 8, 2025
…eras-team#21429) Arbitrary functions and classes are not allowed. - Made `Operation` extend `KerasSaveable`, this required moving imports to avoid circular imports - `Layer` no longer need to extend `KerasSaveable` directly - Made feature space `Cross` and `Feature` extend `KerasSaveable` - Also dissallow public function `enable_unsafe_deserialization`
kharshith-k
pushed a commit
to kharshith-k/keras
that referenced
this pull request
Jul 23, 2025
…eras-team#21429) Arbitrary functions and classes are not allowed. - Made `Operation` extend `KerasSaveable`, this required moving imports to avoid circular imports - `Layer` no longer need to extend `KerasSaveable` directly - Made feature space `Cross` and `Feature` extend `KerasSaveable` - Also dissallow public function `enable_unsafe_deserialization`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arbitrary functions and classes are not allowed.
OperationextendKerasSaveable, this required moving imports to avoid circular importsLayerno longer need to extendKerasSaveabledirectlyCrossandFeatureextendKerasSaveableenable_unsafe_deserialization