Skip to content

Conversation

@fbadine
Copy link
Contributor

@fbadine fbadine commented May 7, 2025

As part of mlx backend support (#19571), this PR adds support for the following functions in linalg.py:

  • lu_factor (supported no in mlx)
  • solve_triangular (currently supported in mlx)
  • lstsq (implemented the same way as TensorFlow's one was implemented)
  • eig (used numpy's implementation until it is supported on mlx)

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Please upload report for BASE (mlx@4970a00). Learn more about missing BASE report.

Files with missing lines Patch % Lines
keras/src/backend/mlx/linalg.py 0.00% 39 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             mlx   #21260   +/-   ##
======================================
  Coverage       ?   75.79%           
======================================
  Files          ?      577           
  Lines          ?    57954           
  Branches       ?     8998           
======================================
  Hits           ?    43925           
  Misses         ?    11995           
  Partials       ?     2034           
Flag Coverage Δ
keras 75.61% <0.00%> (?)
keras-jax 60.70% <0.00%> (?)
keras-numpy 56.11% <0.00%> (?)
keras-tensorflow 61.00% <0.00%> (?)
keras-torch 59.95% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Nice work!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 8, 2025
@fchollet fchollet merged commit 3442cca into keras-team:mlx May 8, 2025
6 of 9 checks passed
@gbaned gbaned added this to PR Queue May 9, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue May 9, 2025
@fbadine fbadine deleted the mlx_linalg branch May 11, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run ready to pull Ready to be merged into the codebase size:M

Projects

Status: Assigned Reviewer

Development

Successfully merging this pull request may close these issues.

4 participants