warning: this `map_or` can be simplified --> frontend/desktop/src/ui.rs:736:9 | 736 | self.emu.as_ref().map_or(false, |emu| emu.playing) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 736 - self.emu.as_ref().map_or(false, |emu| emu.playing) 736 + self.emu.as_ref().is_some_and(|emu| emu.playing) |

warning: large size difference between variants --> frontend/desktop/src/ui/window.rs:518:1 | 518 | / enum WindowState { 519 | | New(NewWindow), | | -------------- the second-largest variant contains at least 104 bytes 520 | | Shown(Window), | | ------------- the largest variant contains at least 928 bytes 521 | | } | |_^ the entire enum is at least 928 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` implied by `#[warn(clippy::all)]` help: consider boxing the large fields to reduce the total size of the enum | 520 - Shown(Window), 520 + Shown(Box<Window>), |

warning: variables can be used directly in the `format!` string --> frontend/desktop/src/ui/savestate_editor.rs:310:39 | 310 | warnings.push(format!("Couldn't load savestate at {:?}: {err}", path)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 310 - warnings.push(format!("Couldn't load savestate at {:?}: {err}", path)); 310 + warnings.push(format!("Couldn't load savestate at {path:?}: {err}")); |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/save_slot_editor.rs:21:13 | 21 | emu_state.as_ref().map_or(false, |emu| emu.game_loaded), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 21 - emu_state.as_ref().map_or(false, |emu| emu.game_loaded), 21 + emu_state.as_ref().is_some_and(|emu| emu.game_loaded), |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/config_editor.rs:1926:33 | 1926 | self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 1926 - self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); 1926 + self.data.game_loaded = emu_state.as_ref().is_some_and(|e| e.game_loaded); |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/config_editor.rs:1332:41 | 1332 | self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 1332 - self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); 1332 + self.data.game_loaded = emu_state.as_ref().is_some_and(|e| e.game_loaded); |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/config_editor/input_map.rs:176:16 | 176 | && trigger | ________________^ 177 | | .as_ref() 178 | | .map_or(false, |trigger| trigger.activated(&self.pressed_keys))) | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `#[warn(clippy::unnecessary_map_or)]` implied by `#[warn(clippy::all)]` help: use is_some_and instead | 178 - .map_or(false, |trigger| trigger.activated(&self.pressed_keys))) 178 + .is_some_and(|trigger| trigger.activated(&self.pressed_keys))) |

warning: variables can be used directly in the `format!` string --> frontend/desktop/src/input/trigger.rs:132:62 | 132 | Self::MismatchedOperators { expected, found } => write!( | ______________________________________________________________^ 133 | | f, 134 | | "mismatched operators: expected {}, found {}", 135 | | expected, found 136 | | ), | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args note: the lint level is defined here --> frontend/desktop/src/main.rs:8:9 | 8 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::all)]`

warning: use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead --> frontend/desktop/src/ui/window.rs:599:33 | 599 | let _ = self.event_loop.run(move |event, elwt| { | ^^^ | = note: `#[warn(deprecated)]` on by default

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/window.rs:434:52 | 434 | let content_layout_rect: NSRect = unsafe { msg_send![ns_window, contentLayoutRect] }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/window.rs:425:27 | 425 | Some(unsafe { msg_send![window.ns_view.as_ptr() as id, window] }) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/window.rs:398:25 | 398 | None => msg_send![string, init], | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/window.rs:393:21 | 393 | / msg_send![string, 394 | | initWithBytes:bytes.as_ptr() 395 | | length:bytes.len() 396 | | encoding:UTF8_ENCODING as id] | |___________________________________________________________^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/window.rs:388:40 | 388 | let string: id = msg_send![class!(NSString), alloc]; | ^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `class` crate for guidance on how handle this unexpected cfg = help: the macro `class` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `class` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/window.rs:388:30 | 388 | let string: id = msg_send![class!(NSString), alloc]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/title_menu_bar.rs:194:43 | 194 | let workspace: id = msg_send![class!(NSWorkspace), sharedWorkspace]; | ^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `class` crate for guidance on how handle this unexpected cfg = help: the macro `class` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `class` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/title_menu_bar.rs:187:43 | 187 | let image: id = msg_send![class!(NSImage), alloc]; | ^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `class` crate for guidance on how handle this unexpected cfg = help: the macro `class` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `class` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/title_menu_bar.rs:187:33 | 187 | let image: id = msg_send![class!(NSImage), alloc]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/title_menu_bar.rs:180:17 | 180 | / msg_send![string, 181 | | initWithBytes:bytes.as_ptr() 182 | | length:bytes.len() 183 | | encoding:UTF8_ENCODING as id] | |_________________________________________________^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/title_menu_bar.rs:178:44 | 178 | let string: id = msg_send![class!(NSString), alloc]; | ^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `class` crate for guidance on how handle this unexpected cfg = help: the macro `class` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `class` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/title_menu_bar.rs:178:34 | 178 | let string: id = msg_send![class!(NSString), alloc]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: this `map_or` can be simplified --> frontend/desktop/src/ui.rs:736:9 | 736 | self.emu.as_ref().map_or(false, |emu| emu.playing) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 736 - self.emu.as_ref().map_or(false, |emu| emu.playing) 736 + self.emu.as_ref().is_some_and(|emu| emu.playing) |

warning: large size difference between variants --> frontend/desktop/src/ui/window.rs:518:1 | 518 | / enum WindowState { 519 | | New(NewWindow), | | -------------- the second-largest variant contains at least 104 bytes 520 | | Shown(Window), | | ------------- the largest variant contains at least 1120 bytes 521 | | } | |_^ the entire enum is at least 1120 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` implied by `#[warn(clippy::all)]` help: consider boxing the large fields to reduce the total size of the enum | 520 - Shown(Window), 520 + Shown(Box<Window>), |

warning: variables can be used directly in the `format!` string --> frontend/desktop/src/ui/savestate_editor.rs:310:39 | 310 | warnings.push(format!("Couldn't load savestate at {:?}: {err}", path)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 310 - warnings.push(format!("Couldn't load savestate at {:?}: {err}", path)); 310 + warnings.push(format!("Couldn't load savestate at {path:?}: {err}")); |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/save_slot_editor.rs:21:13 | 21 | emu_state.as_ref().map_or(false, |emu| emu.game_loaded), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 21 - emu_state.as_ref().map_or(false, |emu| emu.game_loaded), 21 + emu_state.as_ref().is_some_and(|emu| emu.game_loaded), |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/config_editor.rs:1926:33 | 1926 | self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 1926 - self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); 1926 + self.data.game_loaded = emu_state.as_ref().is_some_and(|e| e.game_loaded); |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/config_editor.rs:1332:41 | 1332 | self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 1332 - self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); 1332 + self.data.game_loaded = emu_state.as_ref().is_some_and(|e| e.game_loaded); |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/config_editor/input_map.rs:176:16 | 176 | && trigger | ________________^ 177 | | .as_ref() 178 | | .map_or(false, |trigger| trigger.activated(&self.pressed_keys))) | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `#[warn(clippy::unnecessary_map_or)]` implied by `#[warn(clippy::all)]` help: use is_some_and instead | 178 - .map_or(false, |trigger| trigger.activated(&self.pressed_keys))) 178 + .is_some_and(|trigger| trigger.activated(&self.pressed_keys))) |

warning: variables can be used directly in the `format!` string --> frontend/desktop/src/input/trigger.rs:132:62 | 132 | Self::MismatchedOperators { expected, found } => write!( | ______________________________________________________________^ 133 | | f, 134 | | "mismatched operators: expected {}, found {}", 135 | | expected, found 136 | | ), | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args note: the lint level is defined here --> frontend/desktop/src/main.rs:8:9 | 8 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::all)]`

warning: use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead --> frontend/desktop/src/ui/window.rs:599:33 | 599 | let _ = self.event_loop.run(move |event, elwt| { | ^^^ | = note: `#[warn(deprecated)]` on by default

warning: this `map_or` can be simplified --> frontend/desktop/src/ui.rs:1482:46 | 1482 | ... let active = state.emu.as_ref().map_or( | ____________________________________^ 1483 | | ... false, 1484 | | ... |emu| emu.shared_state.gdb_server_active.load( 1485 | | ... Ordering::Relaxed, 1486 | | ... ), 1487 | | ... ); | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 1482 ~ let active = state.emu.as_ref().is_some_and( 1483 ~ |emu| emu.shared_state.gdb_server_active.load( |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui.rs:736:9 | 736 | self.emu.as_ref().map_or(false, |emu| emu.playing) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 736 - self.emu.as_ref().map_or(false, |emu| emu.playing) 736 + self.emu.as_ref().is_some_and(|emu| emu.playing) |

warning: large size difference between variants --> frontend/desktop/src/ui/window.rs:518:1 | 518 | / enum WindowState { 519 | | New(NewWindow), | | -------------- the second-largest variant contains at least 104 bytes 520 | | Shown(Window), | | ------------- the largest variant contains at least 928 bytes 521 | | } | |_^ the entire enum is at least 928 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` implied by `#[warn(clippy::all)]` help: consider boxing the large fields to reduce the total size of the enum | 520 - Shown(Window), 520 + Shown(Box<Window>), |

warning: variables can be used directly in the `format!` string --> frontend/desktop/src/ui/savestate_editor.rs:310:39 | 310 | warnings.push(format!("Couldn't load savestate at {:?}: {err}", path)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 310 - warnings.push(format!("Couldn't load savestate at {:?}: {err}", path)); 310 + warnings.push(format!("Couldn't load savestate at {path:?}: {err}")); |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/save_slot_editor.rs:21:13 | 21 | emu_state.as_ref().map_or(false, |emu| emu.game_loaded), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 21 - emu_state.as_ref().map_or(false, |emu| emu.game_loaded), 21 + emu_state.as_ref().is_some_and(|emu| emu.game_loaded), |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/config_editor.rs:1926:33 | 1926 | self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 1926 - self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); 1926 + self.data.game_loaded = emu_state.as_ref().is_some_and(|e| e.game_loaded); |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/config_editor.rs:1332:41 | 1332 | self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 1332 - self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); 1332 + self.data.game_loaded = emu_state.as_ref().is_some_and(|e| e.game_loaded); |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/config_editor/input_map.rs:176:16 | 176 | && trigger | ________________^ 177 | | .as_ref() 178 | | .map_or(false, |trigger| trigger.activated(&self.pressed_keys))) | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 178 - .map_or(false, |trigger| trigger.activated(&self.pressed_keys))) 178 + .is_some_and(|trigger| trigger.activated(&self.pressed_keys))) |

warning: variables can be used directly in the `format!` string --> frontend/desktop/src/emu/dldi.rs:21:24 | 21 | base_path.join(format!("{}.bin", index)) | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 21 - base_path.join(format!("{}.bin", index)) 21 + base_path.join(format!("{index}.bin")) |

warning: variables can be used directly in the `format!` string --> frontend/desktop/src/input/trigger.rs:132:62 | 132 | Self::MismatchedOperators { expected, found } => write!( | ______________________________________________________________^ 133 | | f, 134 | | "mismatched operators: expected {}, found {}", 135 | | expected, found 136 | | ), | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::all)]`

warning: this `map_or` can be simplified --> frontend/desktop/src/debug_views/fs.rs:907:25 | 907 | / export.finish_time.as_ref().map_or(true, |finish_time| { 908 | | now - *finish_time < InProgressExport::FADE_OUT_DURATION 909 | | }) | |__________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `#[warn(clippy::unnecessary_map_or)]` implied by `#[warn(clippy::all)]` help: use is_none_or instead | 907 - export.finish_time.as_ref().map_or(true, |finish_time| { 907 + export.finish_time.as_ref().is_none_or(|finish_time| { |

warning: useless conversion to the same type: `debug_views::bg_maps_2d::BgFetchMode` --> frontend/desktop/src/debug_views/bg_maps_2d.rs:736:44 | 736 | (self.selection.0, self.selection.1.map(Into::into)) | ^^^^^^^^^^^^^^^^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion note: the lint level is defined here --> frontend/desktop/src/main.rs:8:9 | 8 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::useless_conversion)]` implied by `#[warn(clippy::all)]`

warning: use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead --> frontend/desktop/src/ui/window.rs:599:33 | 599 | let _ = self.event_loop.run(move |event, elwt| { | ^^^ | = note: `#[warn(deprecated)]` on by default

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/window.rs:434:52 | 434 | let content_layout_rect: NSRect = unsafe { msg_send![ns_window, contentLayoutRect] }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/window.rs:425:27 | 425 | Some(unsafe { msg_send![window.ns_view.as_ptr() as id, window] }) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/window.rs:398:25 | 398 | None => msg_send![string, init], | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/window.rs:393:21 | 393 | / msg_send![string, 394 | | initWithBytes:bytes.as_ptr() 395 | | length:bytes.len() 396 | | encoding:UTF8_ENCODING as id] | |___________________________________________________________^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/window.rs:388:40 | 388 | let string: id = msg_send![class!(NSString), alloc]; | ^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `class` crate for guidance on how handle this unexpected cfg = help: the macro `class` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `class` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/window.rs:388:30 | 388 | let string: id = msg_send![class!(NSString), alloc]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/title_menu_bar.rs:194:43 | 194 | let workspace: id = msg_send![class!(NSWorkspace), sharedWorkspace]; | ^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `class` crate for guidance on how handle this unexpected cfg = help: the macro `class` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `class` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/title_menu_bar.rs:194:33 | 194 | let workspace: id = msg_send![class!(NSWorkspace), sharedWorkspace]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/title_menu_bar.rs:188:17 | 188 | msg_send![image, initByReferencingFile:path] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/title_menu_bar.rs:187:43 | 187 | let image: id = msg_send![class!(NSImage), alloc]; | ^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `class` crate for guidance on how handle this unexpected cfg = help: the macro `class` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `class` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/title_menu_bar.rs:178:44 | 178 | let string: id = msg_send![class!(NSString), alloc]; | ^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `class` crate for guidance on how handle this unexpected cfg = help: the macro `class` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `class` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unexpected `cfg` condition value: `cargo-clippy` --> frontend/desktop/src/ui/title_menu_bar.rs:178:34 | 178 | let string: id = msg_send![class!(NSString), alloc]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `debug-views`, `discord-presence`, `discord-rpc`, `dldi`, `fatfs`, `gdb-protocol`, `gdb-server`, `imgui-memory-editor`, `interp-arm9-interlocks`, `interp-pipeline`, `interp-pipeline-accurate-reloads`, `interp-r15-write-checks`, `interp-timing-details`, `jit`, `log`, `logging`, `png`, `pu-checks`, `realfft`, `slog`, `slog-async`, `slog-imgui`, `slog-term`, `tempfile`, and `xq-audio` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `sel_impl` crate for guidance on how handle this unexpected cfg = help: the macro `sel_impl` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default = note: this warning originates in the macro `sel_impl` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unnecessary semicolon --> core/src/cpu/disasm/arm/other.rs:9:6 | 9 | }; | ^ help: remove | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon note: the lint level is defined here --> core/src/lib.rs:12:9 | 12 | #![warn(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::unnecessary_semicolon)]` implied by `#[warn(clippy::pedantic)]`

warning: variables can be used directly in the `format!` string --> core/build.rs:887:43 | 887 | ... WbOff::Imm => write!( | _____________________________________^ 888 | | ... file, 889 | | ... "load_store_wb::<{}, {}, {{WbOffTy::Imm}}, {}, \ 890 | | ... {{WbAddressing::{}}}>", 891 | | ... load, byte, offset_upwards, addressing 892 | | ... ), | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `#[warn(clippy::uninlined_format_args)]` on by default

warning: this `map_or` can be simplified --> frontend/desktop/src/ui.rs:1482:46 | 1482 | ... let active = state.emu.as_ref().map_or( | ____________________________________^ 1483 | | ... false, 1484 | | ... |emu| emu.shared_state.gdb_server_active.load( 1485 | | ... Ordering::Relaxed, 1486 | | ... ), 1487 | | ... ); | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 1482 ~ let active = state.emu.as_ref().is_some_and( 1483 ~ |emu| emu.shared_state.gdb_server_active.load( |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui.rs:736:9 | 736 | self.emu.as_ref().map_or(false, |emu| emu.playing) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 736 - self.emu.as_ref().map_or(false, |emu| emu.playing) 736 + self.emu.as_ref().is_some_and(|emu| emu.playing) |

warning: large size difference between variants --> frontend/desktop/src/ui/window.rs:518:1 | 518 | / enum WindowState { 519 | | New(NewWindow), | | -------------- the second-largest variant contains at least 104 bytes 520 | | Shown(Window), | | ------------- the largest variant contains at least 1120 bytes 521 | | } | |_^ the entire enum is at least 1120 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` implied by `#[warn(clippy::all)]` help: consider boxing the large fields to reduce the total size of the enum | 520 - Shown(Window), 520 + Shown(Box<Window>), |

warning: variables can be used directly in the `format!` string --> frontend/desktop/src/ui/savestate_editor.rs:310:39 | 310 | warnings.push(format!("Couldn't load savestate at {:?}: {err}", path)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 310 - warnings.push(format!("Couldn't load savestate at {:?}: {err}", path)); 310 + warnings.push(format!("Couldn't load savestate at {path:?}: {err}")); |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/save_slot_editor.rs:21:13 | 21 | emu_state.as_ref().map_or(false, |emu| emu.game_loaded), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 21 - emu_state.as_ref().map_or(false, |emu| emu.game_loaded), 21 + emu_state.as_ref().is_some_and(|emu| emu.game_loaded), |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/config_editor.rs:1926:33 | 1926 | self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 1926 - self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); 1926 + self.data.game_loaded = emu_state.as_ref().is_some_and(|e| e.game_loaded); |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/config_editor.rs:1332:41 | 1332 | self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 1332 - self.data.game_loaded = emu_state.as_ref().map_or(false, |e| e.game_loaded); 1332 + self.data.game_loaded = emu_state.as_ref().is_some_and(|e| e.game_loaded); |

warning: this `map_or` can be simplified --> frontend/desktop/src/ui/config_editor/input_map.rs:176:16 | 176 | && trigger | ________________^ 177 | | .as_ref() 178 | | .map_or(false, |trigger| trigger.activated(&self.pressed_keys))) | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or help: use is_some_and instead | 178 - .map_or(false, |trigger| trigger.activated(&self.pressed_keys))) 178 + .is_some_and(|trigger| trigger.activated(&self.pressed_keys))) |

warning: variables can be used directly in the `format!` string --> frontend/desktop/src/emu/dldi.rs:21:24 | 21 | base_path.join(format!("{}.bin", index)) | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 21 - base_path.join(format!("{}.bin", index)) 21 + base_path.join(format!("{index}.bin")) |

warning: variables can be used directly in the `format!` string --> frontend/desktop/src/input/trigger.rs:132:62 | 132 | Self::MismatchedOperators { expected, found } => write!( | ______________________________________________________________^ 133 | | f, 134 | | "mismatched operators: expected {}, found {}", 135 | | expected, found 136 | | ), | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::all)]`

warning: this `map_or` can be simplified --> frontend/desktop/src/debug_views/fs.rs:907:25 | 907 | / export.finish_time.as_ref().map_or(true, |finish_time| { 908 | | now - *finish_time < InProgressExport::FADE_OUT_DURATION 909 | | }) | |__________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `#[warn(clippy::unnecessary_map_or)]` implied by `#[warn(clippy::all)]` help: use is_none_or instead | 907 - export.finish_time.as_ref().map_or(true, |finish_time| { 907 + export.finish_time.as_ref().is_none_or(|finish_time| { |

warning: useless conversion to the same type: `debug_views::bg_maps_2d::BgFetchMode` --> frontend/desktop/src/debug_views/bg_maps_2d.rs:736:44 | 736 | (self.selection.0, self.selection.1.map(Into::into)) | ^^^^^^^^^^^^^^^^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion note: the lint level is defined here --> frontend/desktop/src/main.rs:8:9 | 8 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::useless_conversion)]` implied by `#[warn(clippy::all)]`

warning: use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead --> frontend/desktop/src/ui/window.rs:599:33 | 599 | let _ = self.event_loop.run(move |event, elwt| { | ^^^ | = note: `#[warn(deprecated)]` on by default

warning: unnecessary semicolon --> core/src/cpu/disasm/arm/other.rs:9:6 | 9 | }; | ^ help: remove | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon note: the lint level is defined here --> core/src/lib.rs:12:9 | 12 | #![warn(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::unnecessary_semicolon)]` implied by `#[warn(clippy::pedantic)]`

warning: variables can be used directly in the `format!` string --> core/build.rs:902:25 | 902 | / write!( 903 | | file, 904 | | "ldm_stm::<{}, {}, {}, {}, {}>", 905 | | load, increment, base_excluded, writeback, s_bit 906 | | ) | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args