Don't allow adding to lists from attributes. #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Collection syntax](https://learn.microsoft.com/en-us/dotnet/desktop/wpf/advanced/xaml-syntax-in-detail?view=netframeworkdesktop-4.8#collection-syntax) in XAML should only be supported when setting property values using property element syntax and not attribute syntax. Adds a property to `XamlAstXamlPropertyValueNode` to indicate whether the property value came from an attribute, and a property to `PropertySetterBinderParameters` to indicate whether a setter can be used from an attribute. The `AdderSetter`s set `PropertySetterBinderParameters.AllowAttributeSyntax` to false, which disallows their usage from attribute `XamlAstXamlPropertyValueNode`s.
kekekeks
approved these changes
Apr 13, 2023
grokys
added a commit
to AvaloniaUI/Avalonia
that referenced
this pull request
Apr 13, 2023
Depends on kekekeks/XamlX#85: this PR disallows invoking "collection behavior" for property setters when using attribute syntax. Required adding a `Flyout.FlyoutPresenterClasses` setter. This property was previously buggy without the setter (see #10946 (comment)). Added tests for setting classes that I put in place when investigating this. Fixes #10946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection syntax in XAML should only be supported when setting property values using property element syntax and not attribute syntax.
Adds a property to
XamlAstXamlPropertyValueNodeto indicate whether the property value came from an attribute, and a property toPropertySetterBinderParametersto indicate whether a setter can be used from an attribute.The
AdderSetters setPropertySetterBinderParameters.AllowAttributeSyntaxto false, which disallows their usage from attributeXamlAstXamlPropertyValueNodes.Updated the unit tests to ensure that markup extensions cannot now be used to add items to read-only collections (but can be used to assign lists to read-write collection properties).
Required for AvaloniaUI/Avalonia#10946