fix: LaunchTemplates to set InstanceMetadataTags as "disabled" #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Downey <[email protected]>
Signed-off-by: Kevin Downey <[email protected]>
Signed-off-by: Kevin Downey <[email protected]>
Signed-off-by: Kevin Downey <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #503 +/- ##
==========================================
+ Coverage 46.57% 46.66% +0.08%
==========================================
Files 40 40
Lines 7094 7096 +2
==========================================
+ Hits 3304 3311 +7
+ Misses 3632 3627 -5
Partials 158 158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vgunapati
reviewed
Jul 10, 2025
| properties: | ||
| configuration: | ||
| properties: | ||
| nodeConfig: |
There was a problem hiding this comment.
why are we removing nodeConfig
There was a problem hiding this comment.
This is being removed by generate, make manifests. I asked @estela-ramirez and she confirmed we don't need this.
vgunapati
reviewed
Jul 10, 2025
| HttpEndpoint: aws.String(input.HttpEndpoint), | ||
| HttpPutResponseHopLimit: aws.Int64(input.HttpPutHopLimit), | ||
| HttpTokens: aws.String(input.HttpTokens), | ||
| InstanceMetadataTags: aws.String("disabled"), // set disabled by default |
There was a problem hiding this comment.
do we need update CRD in instancemgr.keikoproj.io_instancegroups.yaml
metadataOptions:
properties:
httpEndpoint:
type: string
httpPutHopLimit:
format: int64
type: integer
httpTokens:
type: string
type: object
There was a problem hiding this comment.
No, we do not expose this for configuration in IG spec (input), it's hard-coded as "disabled" only
shreyas-badiger
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Fixes issue where IGs using LaunchTemplates may inherit
InstanceMetadataTags="enabled"property as an account setting but it won't work for Kubernetes Nodes due to a restriction of using "/" characters which conflicts withkubernetes.io/cluster/<clustername>tagging.This change will always set
InstanceMetadataTagsas "disabled"Related issue(s)
High-level overview of changes
Testing performed
Checklist
make testlocally and all tests passgit commit -sfor DCO verificationAdditional information