Skip to content

Conversation

@tekenstam
Copy link
Member

What this PR does / why we need it

This PR addresses two issues with the container image workflow:

  1. Registry Authentication: Fixes the image-push workflow that was failing with the error "No credentials found for registry keikoproj" by explicitly specifying the Docker registry.

  2. Multi-arch Image Annotations: Adds proper annotations to multi-architecture container images using the correct annotation-index syntax, addressing the GitHub Packages warning about missing image description.

Changes made

  • Added explicit docker.io/ prefix to all Docker image references
  • Implemented the recommended annotation-index syntax for multi-arch manifests
  • Added comprehensive OCI annotations (description, license, source, etc.)
  • Disabled duplicate provenance to avoid conflicts with the dedicated attestation actions

How to verify it

  • The image-push GitHub Action workflow should now successfully authenticate
  • Multi-arch images should display proper metadata in GitHub Packages including description
  • SLSA attestations should be correctly generated for both DockerHub and GitHub Container Registry

@tekenstam tekenstam requested review from a team as code owners April 14, 2025 18:53
@tekenstam tekenstam merged commit bd8fb2a into master Apr 14, 2025
4 of 5 checks passed
@tekenstam tekenstam deleted the fix/multi-arch-annotations branch April 14, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants