Skip to content

Conversation

@tekenstam
Copy link
Member

What this PR does / why we need it

This PR addresses two issues with the container image workflow:

  1. Registry Authentication: Fixes the image-push workflow that was failing with the error "No credentials found for registry keikoproj". The issue was caused by not explicitly specifying the Docker registry, causing Docker to interpret "keikoproj" as a registry name rather than an organization on DockerHub.

  2. Multi-arch Image OCI Annotations: Enhances container metadata by properly configuring the OCI annotations in the manifest list for multi-architecture images, addressing GitHub Packages warnings about missing metadata.

Changes made

  • Added explicit docker.io/ prefix to all Docker image references in the workflow
  • Added complete set of OCI annotations to properly document the container images
  • Configured the manifest list to include annotations for multi-arch images
  • Removed redundancy in metadata configuration by using consistent output references
  • Added mandatory annotations including description, created date, version, and Git revision

How to verify it

  • The image-push GitHub Action workflow should successfully authenticate with Docker registries
  • Multi-arch images should display proper metadata in container registries
  • Annotations should be visible in both DockerHub and GitHub Container Registry

Additional Notes

This PR follows OCI (Open Container Initiative) standards for container metadata, enhancing the discoverability and documentation of our container images.

@tekenstam tekenstam requested review from a team as code owners April 14, 2025 18:37
@tekenstam tekenstam merged commit 49204ce into master Apr 14, 2025
6 checks passed
@tekenstam tekenstam deleted the fix/image-push-oci-annotations branch April 14, 2025 18:38
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.13%. Comparing base (002b453) to head (e38486a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files          40       40           
  Lines        7004     7004           
=======================================
  Hits         3231     3231           
  Misses       3617     3617           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants