Skip to content

Conversation

@tekenstam
Copy link
Member

Summary

This PR resolves authentication issues with GitHub Container Registry (GHCR) in our Docker image build workflow.

Changes

Authentication Fixes

  • Improved authentication with GitHub Container Registry using appropriate credentials
  • Updated container registry permissions in the workflow configuration
  • Fixed build provenance attestation to properly work with both registries

Context

The previous image build improvements (PR #475) were unable to properly authenticate with GHCR, resulting in 403 Forbidden errors when attempting to push images. This PR specifically addresses those authentication issues.

Testing

The workflow has been tested to verify:

  1. Proper authentication with both DockerHub and GitHub Container Registry
  2. Correct image tagging and pushing to both registries
  3. Generation of build provenance attestations

Related PRs

Builds on and fixes issues introduced in PR #475

@tekenstam tekenstam requested review from a team as code owners April 14, 2025 04:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.13%. Comparing base (605f56f) to head (79c4858).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #475   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files          40       40           
  Lines        7004     7004           
=======================================
  Hits         3231     3231           
  Misses       3617     3617           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tekenstam tekenstam merged commit cea9f17 into master Apr 14, 2025
7 checks passed
@tekenstam tekenstam deleted the fix-image-push2 branch April 14, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants