Skip to content

Conversation

@tekenstam
Copy link
Member

Fix Docker Image Build Process

Summary

This PR fixes issues with the Docker image build workflow to properly support GitHub Container Registry (GHCR) publishing.

Changes

Workflow Improvements

  • Renamed workflow from push.yml to image-push.yml for better clarity of purpose
  • Added necessary package write permissions for GitHub Container Registry push
  • Fixed authentication issues with GHCR

Context

Our previous attempt to improve the Docker image build process (PR #474) encountered authentication issues when pushing to GitHub Container Registry. This PR specifically addresses those authentication problems while maintaining the other improvements.

Testing

The workflow has been tested to ensure:

  1. Proper authentication with GitHub Container Registry
  2. Correct permissions for pushing Docker images
  3. Maintaining all the previous build improvements

Related PRs

Builds on PR #474

@tekenstam tekenstam requested review from a team as code owners April 14, 2025 03:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.13%. Comparing base (1b56900) to head (80986fa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files          40       40           
  Lines        7004     7004           
=======================================
  Hits         3231     3231           
  Misses       3617     3617           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tekenstam tekenstam merged commit 605f56f into master Apr 14, 2025
7 checks passed
@tekenstam tekenstam deleted the fix-image-push3 branch April 14, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants