Skip to content

fix incorrect counter name #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix incorrect counter name #409

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cce53a
fix incorrect counter name
ZihanJiang96 Oct 13, 2023
388d0c8
add failure reason
ZihanJiang96 Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/common/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func (c *MetricsCollector) IncSuccess(instanceGroup string) {
}

func (c *MetricsCollector) IncFail(instanceGroup, reason string) {
c.successCounter.With(prometheus.Labels{"instancegroup": instanceGroup}).Inc()
c.failureCounter.With(prometheus.Labels{"instancegroup": instanceGroup}).Inc()
}

func (c *MetricsCollector) IncThrottle(serviceName, operationName string) {
Expand Down