Enforce Restricted Fields usage when no default value #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
eytan-avisror
commented
Feb 4, 2022
controllers/provisioners/config.go
Outdated
| // if no default value exist, make sure to ignore CR value for restricted fields | ||
| err := unstructured.SetNestedField(unstructuredInstanceGroup, nil, path...) | ||
| if err != nil { | ||
| errors.Wrap(err, "failed to set nested field to nil") |
There was a problem hiding this comment.
@backjo I just noticed we are not returning any of these errors here.. do you remember if we did this intentionally? Thinking we should return these errors to caller WDYT
There was a problem hiding this comment.
👍 I don't think it was intentional
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 51.15% 51.15% -0.01%
==========================================
Files 33 33
Lines 4510 4514 +4
==========================================
+ Hits 2307 2309 +2
- Misses 2062 2063 +1
- Partials 141 142 +1
Continue to review full report at Codecov.
|
Signed-off-by: Eytan Avisror <[email protected]>
backjo
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eytan Avisror [email protected]
Fixes #341
This fixes a gap in our admin configuration where we allow CRs to use restricted fields if there are no defaults.
This change sets field to Nil if there is no default value provided and field is a restricted field.