Skip to content

Conversation

@eytan-avisror
Copy link
Collaborator

Signed-off-by: Eytan Avisror [email protected]
Fix #308

This fixes a bug where controller-added tags are not evaluated when reconciling.

Signed-off-by: Eytan Avisror <[email protected]>
@eytan-avisror eytan-avisror requested review from a team as code owners June 8, 2021 23:40
@eytan-avisror eytan-avisror requested a review from backjo June 8, 2021 23:40
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #314 (6e702bd) into master (6a04c23) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   70.05%   70.20%   +0.14%     
==========================================
  Files          19       19              
  Lines        3156     3175      +19     
==========================================
+ Hits         2211     2229      +18     
- Misses        804      805       +1     
  Partials      141      141              
Impacted Files Coverage Δ
controllers/provisioners/eks/cloud.go 84.00% <100.00%> (+0.07%) ⬆️
controllers/provisioners/eks/helpers.go 91.67% <100.00%> (+0.19%) ⬆️
controllers/provisioners/eks/update.go 79.81% <100.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5c8ae...6e702bd. Read the comment docs.

@eytan-avisror eytan-avisror merged commit ffdd96a into keikoproj:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TagsUpdateNeeded does not account for controller-added tags

2 participants