Skip to content

Conversation

@miyamo2
Copy link

@miyamo2 miyamo2 commented Nov 25, 2025

This PR improves the error message when the awsSecretAccessKey is missing from credentials.
Previously, the error returned was awsAccessKeyID not found, but now it returns awsSecretAccessKey not found, which better matches the actual problem.

For some AWS-related Scaler's tests, the relevant test patterns have already been tested, so no changes have been made.

Checklist

@miyamo2 miyamo2 requested a review from a team as a code owner November 25, 2025 11:31
@github-actions
Copy link

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

  • Add an entry in our changelog in alphabetical order and link related issue
  • Update the documentation, if needed
  • Add unit & e2e tests for your changes
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

@keda-automation keda-automation requested a review from a team November 25, 2025 11:31
@snyk-io
Copy link

snyk-io bot commented Nov 25, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Signed-off-by: miyamo2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant