feat: Add support to enable backoff when rate limited by the Github API #7192
+204
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
pkg/scalers/github_runner_scaler.go
Outdated
| if retryAfterStr := header.Get("Retry-After"); retryAfterStr != "" { | ||
| retrySeconds, err := strconv.Atoi(retryAfterStr) | ||
| if err != nil { | ||
| return RateLimit{}, fmt.Errorf("failed to parse Retry-After header. Returned error: %s", err.Error()) |
There was a problem hiding this comment.
Semgrep found a possible error wrong wrapped.
🥳 Fixed in commit 9e21288 🥳
pkg/scalers/github_runner_scaler.go
Outdated
| resetStr := header.Get("X-RateLimit-Reset") | ||
| reset, err := strconv.ParseInt(resetStr, 10, 64) | ||
| if err != nil { | ||
| return RateLimit{}, fmt.Errorf("failed to parse X-RateLimit-Reset header. Returned error: %s", err.Error()) |
There was a problem hiding this comment.
Semgrep found a possible error wrong wrapped.
🥳 Fixed in commit 9e21288 🥳
pkg/scalers/github_runner_scaler.go
Outdated
| remainingStr := header.Get("X-RateLimit-Remaining") | ||
| remaining, err := strconv.Atoi(remainingStr) | ||
| if err != nil { | ||
| return RateLimit{}, fmt.Errorf("failed to parse X-RateLimit-Remaining header. Returned error: %s", err.Error()) |
There was a problem hiding this comment.
Semgrep found a possible error wrong wrapped.
🍰 Fixed in commit 9e21288 🍰
Signed-off-by: andrewhibbert <[email protected]>
Signed-off-by: andrewhibbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to backoff when a rate limit error occurs as per handle rate limit errors appropriately:
Fixes #6643
Relates to kedacore/keda-docs#1557