refactor: rename temporal scaler files for consistency #6911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniruddhc1
force-pushed
the
rename-temporal-scaler
branch
4 times, most recently
from
4c1e94e to
72bf857
Compare
Renames the temporal scaler files to follow the convention used by other scalers in the project. - -> - -> - -> Signed-off-by: Aniruddh Chaturvedi <[email protected]>
aniruddhc1
force-pushed
the
rename-temporal-scaler
branch
from
72bf857 to
ab530c4
Compare
Member
|
Thanks! This PR is related to discussion here: kedacore/keda-docs#1574 |
Member
|
Hi @aniruddhc1 , Could you revert this file rename (tests/scalers/temporal_scaler/temporal_scaler_test.go)? |
aniruddhc1
force-pushed
the
rename-temporal-scaler
branch
2 times, most recently
from
47aec46 to
15dc6ef
Compare
Signed-off-by: Aniruddh Chaturvedi <[email protected]>
aniruddhc1
force-pushed
the
rename-temporal-scaler
branch
from
15dc6ef to
758ce57
Compare
Contributor
Author
|
Looks like I need one more reviewer to merge this PR. @rickbrouwer , could you find me someone? |
Member
|
No worries, someone will pick it up soon :) |
JorTurFer
approved these changes
Jul 27, 2025
Member
|
/skip-e2e |
kmoonwright
pushed a commit
to kmoonwright/keda
that referenced
this pull request
Jul 29, 2025
* refactor: rename temporal scaler files for consistency Renames the temporal scaler files to follow the convention used by other scalers in the project. - -> - -> - -> Signed-off-by: Aniruddh Chaturvedi <[email protected]> * address feedback Signed-off-by: Aniruddh Chaturvedi <[email protected]> --------- Signed-off-by: Aniruddh Chaturvedi <[email protected]> Signed-off-by: Aniruddh Chaturvedi <[email protected]> Signed-off-by: kmoonwright <[email protected]>
dpochopsky
pushed a commit
to dpochopsky/keda
that referenced
this pull request
Sep 12, 2025
* refactor: rename temporal scaler files for consistency Renames the temporal scaler files to follow the convention used by other scalers in the project. - -> - -> - -> Signed-off-by: Aniruddh Chaturvedi <[email protected]> * address feedback Signed-off-by: Aniruddh Chaturvedi <[email protected]> --------- Signed-off-by: Aniruddh Chaturvedi <[email protected]> Signed-off-by: Aniruddh Chaturvedi <[email protected]> Signed-off-by: David Pochopsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the temporal scaler files to follow the convention used by other scalers in the project.
Renames the temporal scaler files to follow the convention used by other scalers in the project.
Checklist
Fixes #
Relates to #