Clarify queueLengthStrategy description in docs for Azure Queue Autoscaling #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed while reviewing the code for this path (https://github.com/kedacore/keda/blob/e89626a16563735b8cc6211fbcbdc43e51d37d15/pkg/scalers/azure_queue_scaler.go), that I had originally misinterpreted how the visibleonly queue length strategy works. This PR tries to clarify the mistaken behavior by making it explicit that the count that has to be 32 or higher before falling back to the regular behavior is that of the visible messages not the queue overall. Signed-off-by: Esteban Rey <[email protected]>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
estebanreyl
changed the title
JorTurFer
reviewed
Oct 25, 2025
Member
JorTurFer
left a comment
JorTurFer
left a comment
There was a problem hiding this comment.
Thanks for the clarification! Could you apply to other versions too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while reviewing the code for this path (https://github.com/kedacore/keda/blob/e89626a16563735b8cc6211fbcbdc43e51d37d15/pkg/scalers/azure_queue_scaler.go), that I had originally misinterpreted how the visibleonly queue length strategy works. This PR tries to clarify the mistaken behavior by making it explicit that the count that has to be 32 or higher before falling back to the regular behavior is that of the visible messages not the queue overall.
Provide a description of what has been changed
Checklist
Fixes #