Add ability to add extra ENV vars to containers#777
Merged
wozniakjan merged 8 commits intokedacore:mainfrom Oct 6, 2025
Merged
Add ability to add extra ENV vars to containers#777wozniakjan merged 8 commits intokedacore:mainfrom
wozniakjan merged 8 commits intokedacore:mainfrom
Conversation
robinderooij-rl
force-pushed
the
add-extra-env-vars
branch
from
373b799 to
0b37a03
Compare
4 tasks
JorTurFer
reviewed
Sep 29, 2025
The http-add-on chart did not have the ability yet to add custom extra env variables to the deployments. This implements it according to the standard set in the PR implementing the extra container ags, using an object instead of a list of objects. (See for this PR: kedacore#245) A previous PR was already made some time ago but it did not adhere to the requested convention: kedacore#762 This PR tries to solve that issue. Signed-off-by: Robin de Rooij <[email protected]>
* Allow Keda to request SA tokens Signed-off-by: Bojan Zelic <[email protected]> * Allow Keda to request SA tokens Signed-off-by: Bojan Zelic <[email protected]> * Allow Keda to request SA tokens Signed-off-by: Bojan Zelic <[email protected]> --------- Signed-off-by: Bojan Zelic <[email protected]> Signed-off-by: Robin de Rooij <[email protected]>
Signed-off-by: Robin de Rooij <[email protected]>
…core#779) Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Robin de Rooij <[email protected]>
Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Robin de Rooij <[email protected]>
robinderooij-rl
force-pushed
the
add-extra-env-vars
branch
from
cb53f35 to
204a73b
Compare
Contributor
Author
|
(Sorry for the awkward commit log by the way, I had to rebase for the DCO signing) |
Signed-off-by: Robin de Rooij <[email protected]>
…ts into add-extra-env-vars
wozniakjan
approved these changes
Oct 6, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The http-add-on chart did not have the ability yet to add custom extra env variables to the deployments. This implements it according to the standard set in the PR implementing the extra container ags, using an object instead of a list of objects. (See for this PR: #245)
A previous PR was already made some time ago but it did not adhere to the requested convention: #762
This PR tries to solve that issue.