feat(metrics-server): add dnsConfig support#771
Merged
wozniakjan merged 1 commit intokedacore:mainfrom Aug 1, 2025
Merged
Conversation
Signed-off-by: Matthew Kevin Amadeus <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds DNS configuration support for the KEDA metrics server component by introducing a new metricsServer.dnsConfig parameter. This enhancement allows users to customize DNS settings specifically for the metrics server pod, providing more flexibility in DNS resolution scenarios.
Key changes:
- Added
metricsServer.dnsConfigconfiguration option to values.yaml with example usage - Updated the metrics server deployment template to conditionally include DNS configuration
- Updated documentation to reflect the new configuration parameter
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| keda/values.yaml | Adds the new dnsConfig parameter with commented examples for nameservers, searches, and options |
| keda/templates/metrics-server/deployment.yaml | Conditionally renders the dnsConfig section in the pod spec when the parameter is provided |
| keda/README.md | Documents the new metricsServer.dnsConfig parameter in the configuration table |
This was referenced Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for configuring DNS settings specifically for the KEDA metrics server pod through the new
metricsServer.dnsConfigparameter invalues.yaml.Usage Example
Checklist