Skip to content

feat(metrics-server): add dnsConfig support#771

Merged
wozniakjan merged 1 commit intokedacore:mainfrom
mkamadeus:dnspolicy-metrics-server
Aug 1, 2025
Merged

feat(metrics-server): add dnsConfig support#771
wozniakjan merged 1 commit intokedacore:mainfrom
mkamadeus:dnspolicy-metrics-server

Conversation

@mkamadeus
Copy link
Contributor

@mkamadeus mkamadeus commented Jul 25, 2025

Changes

This PR adds support for configuring DNS settings specifically for the KEDA metrics server pod through the new metricsServer.dnsConfig parameter in values.yaml.

Usage Example

metricsServer:
  dnsConfig:
    nameservers:
      - "8.8.8.8"
      - "1.1.1.1"
    searches:
      - "metrics.example.com"
    options:
      - name: "ndots"
        value: "3"

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Signed-off-by: Matthew Kevin Amadeus <[email protected]>
@mkamadeus mkamadeus marked this pull request as ready for review July 25, 2025 06:05
@mkamadeus mkamadeus requested a review from a team as a code owner July 25, 2025 06:05
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wozniakjan wozniakjan requested a review from Copilot August 1, 2025 09:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds DNS configuration support for the KEDA metrics server component by introducing a new metricsServer.dnsConfig parameter. This enhancement allows users to customize DNS settings specifically for the metrics server pod, providing more flexibility in DNS resolution scenarios.

Key changes:

  • Added metricsServer.dnsConfig configuration option to values.yaml with example usage
  • Updated the metrics server deployment template to conditionally include DNS configuration
  • Updated documentation to reflect the new configuration parameter

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
keda/values.yaml Adds the new dnsConfig parameter with commented examples for nameservers, searches, and options
keda/templates/metrics-server/deployment.yaml Conditionally renders the dnsConfig section in the pod spec when the parameter is provided
keda/README.md Documents the new metricsServer.dnsConfig parameter in the configuration table

@wozniakjan wozniakjan merged commit 027843e into kedacore:main Aug 1, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants