Skip to content

Provide better documentation on watching namespaces#107

Merged
tomkerkhove merged 1 commit into
kedacore:masterfrom
tomkerkhove:watch-namespace
Nov 30, 2020
Merged

Provide better documentation on watching namespaces#107
tomkerkhove merged 1 commit into
kedacore:masterfrom
tomkerkhove:watch-namespace

Conversation

@tomkerkhove
Copy link
Copy Markdown
Member

@tomkerkhove tomkerkhove commented Nov 30, 2020

Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com

Improvement for kedacore/keda#1377

Without:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: keda-operator
  namespace: platform-gateway-g3-dev
  labels:
    app: keda-operator
    name: keda-operator
    <redacted>
spec:
  replicas: 1
  selector:
    matchLabels:
      app: keda-operator
  template:
    metadata:
      labels:
        app: keda-operator
    spec:
      serviceAccountName: keda-operator
      securityContext:
        {}
      containers:
        - name: keda-operator
          securityContext:
            {}
          image: "docker.io/kedacore/keda:2.0.0"
          <redacted>
          env:
            - name: WATCH_NAMESPACE
              value: ""
            - name: POD_NAME
              valueFrom:
                fieldRef:
                  fieldPath: metadata.name
            - name: OPERATOR_NAME
              value: keda-operator
          volumeMounts:
          resources:
            {}
      volumes:
---
# Source: keda/templates/22-metrics-deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: keda-operator-metrics-apiserver
  namespace: platform-gateway-g3-dev
  labels:    
    <redacted>
spec:
  replicas: 1
  selector:
    matchLabels:
      app: keda-operator-metrics-apiserver
  template:
    metadata:
      labels:
        app: keda-operator-metrics-apiserver
      annotations:
    spec:
      serviceAccountName: keda-operator
      securityContext:
        {}
      containers:
        - name: keda-operator-metrics-apiserver
          securityContext:
            {}
          image: "docker.io/kedacore/keda-metrics-apiserver:2.0.0"
          <redacted>
          env:
            - name: WATCH_NAMESPACE
              value: ""

With:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: keda-operator
  namespace: platform-gateway-g3-dev
  labels:
    app: keda-operator
    name: keda-operator
    <redacted>
spec:
  replicas: 1
  selector:
    matchLabels:
      app: keda-operator
  template:
    metadata:
      labels:
        app: keda-operator
    spec:
      serviceAccountName: keda-operator
      securityContext:
        {}
      containers:
        - name: keda-operator
          securityContext:
            {}
          image: "docker.io/kedacore/keda:2.0.0"
          <redacted>
          env:
            - name: WATCH_NAMESPACE
              value: "foo"
            - name: POD_NAME
              valueFrom:
                fieldRef:
                  fieldPath: metadata.name
            - name: OPERATOR_NAME
              value: keda-operator
          volumeMounts:
          resources:
            {}
      volumes:
---
# Source: keda/templates/22-metrics-deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: keda-operator-metrics-apiserver
  namespace: platform-gateway-g3-dev
  labels:    
    <redacted>
spec:
  replicas: 1
  selector:
    matchLabels:
      app: keda-operator-metrics-apiserver
  template:
    metadata:
      labels:
        app: keda-operator-metrics-apiserver
      annotations:
    spec:
      serviceAccountName: keda-operator
      securityContext:
        {}
      containers:
        - name: keda-operator-metrics-apiserver
          securityContext:
            {}
          image: "docker.io/kedacore/keda-metrics-apiserver:2.0.0"
          <redacted>
          env:
            - name: WATCH_NAMESPACE
              value: "foo"

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove merged commit fa78913 into kedacore:master Nov 30, 2020
@tomkerkhove tomkerkhove deleted the watch-namespace branch November 30, 2020 09:39
@tomkerkhove tomkerkhove modified the milestones: v2.1.0, v2.0.1 Dec 22, 2020
wozniakjan pushed a commit to wozniakjan/keda-charts that referenced this pull request Feb 3, 2025
* Add rbac for reading logs
* fix schema

Signed-off-by: Josef Karasek <karasek.jose@gmail.com>
wozniakjan pushed a commit to wozniakjan/keda-charts that referenced this pull request Feb 13, 2025
* Add rbac for reading logs
* fix schema

Signed-off-by: Josef Karasek <karasek.jose@gmail.com>
zroubalik pushed a commit to zroubalik/charts that referenced this pull request Feb 20, 2025
* Add rbac for reading logs
* fix schema

Signed-off-by: Josef Karasek <karasek.jose@gmail.com>
zroubalik pushed a commit to zroubalik/charts that referenced this pull request Feb 20, 2025
* Add rbac for reading logs
* fix schema

Signed-off-by: Josef Karasek <karasek.jose@gmail.com>
wozniakjan pushed a commit to wozniakjan/keda-charts that referenced this pull request Feb 21, 2025
* Add rbac for reading logs
* fix schema

Signed-off-by: Josef Karasek <karasek.jose@gmail.com>
zroubalik pushed a commit to zroubalik/charts that referenced this pull request Feb 25, 2025
* Add rbac for reading logs
* fix schema

Signed-off-by: Josef Karasek <karasek.jose@gmail.com>
wozniakjan pushed a commit to wozniakjan/keda-charts that referenced this pull request Mar 3, 2025
* Add rbac for reading logs
* fix schema

Signed-off-by: Josef Karasek <karasek.jose@gmail.com>
wozniakjan pushed a commit to wozniakjan/keda-charts that referenced this pull request Mar 10, 2025
* Add rbac for reading logs
* fix schema

Signed-off-by: Josef Karasek <karasek.jose@gmail.com>
wozniakjan pushed a commit to wozniakjan/keda-charts that referenced this pull request May 19, 2025
* Add rbac for reading logs
* fix schema

Signed-off-by: Josef Karasek <karasek.jose@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants