Skip to content

[PMON] Remove ethtool form pmon docker#81

Closed
keboliu wants to merge 1 commit intomasterfrom
remove_ethtool_from_pmon
Closed

[PMON] Remove ethtool form pmon docker#81
keboliu wants to merge 1 commit intomasterfrom
remove_ethtool_from_pmon

Conversation

@keboliu
Copy link
Copy Markdown
Owner

@keboliu keboliu commented Feb 16, 2023

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@keboliu
Copy link
Copy Markdown
Owner Author

keboliu commented Feb 16, 2023

CI Pass

Copy link
Copy Markdown
Collaborator

@Junchao-Mellanox Junchao-Mellanox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py, there is comment about ethtool, do we want to remove it also?

@keboliu
Copy link
Copy Markdown
Owner Author

keboliu commented Feb 17, 2023

I see in platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py, there is comment about ethtool, do we want to remove it also?

will take a look, and seems with the change the ethtool will also be removed from host side, this is not what I wanted, may need further change.

@liat-grozovik
Copy link
Copy Markdown

@keboliu there is a typo in the subject :-) please fix before upstream
'form' to 'from'

@keboliu keboliu closed this Aug 28, 2023
@keboliu keboliu deleted the remove_ethtool_from_pmon branch August 28, 2023 09:27
keboliu pushed a commit that referenced this pull request Mar 21, 2024
…e latest HEAD automatically (sonic-net#18374)

#### Why I did it
src/wpasupplicant/sonic-wpa-supplicant
```
* 13e6f1100 - (HEAD -> master, origin/master, origin/HEAD) Fix a memory leak introduced by last commit for high level EVP API #82 (64 minutes ago) [xumia]
|\ 
| failure_prs.log 225157a01 - Merge branch 'master' into master (3 days ago) [wumiao_nokia]
| |\ 
| |/ 
|/| 
* | 413704a6c - Provide CMAC high level API replacement #81 (4 days ago) [xumia]
| failure_prs.log c7eafc778 - Fix a memory leak introduced by last commit for high level EVP API for CMAC (3 days ago) [wumiao_nokia]
|/ 
* 8521d4abb - Fix a port issue (6 days ago) [wumiao_nokia]
* 01a39044a - Provide CMAC high level API replacement (6 days ago) [wumiao_nokia]
```
#### How I did it
#### How to verify it
#### Description for the changelog
keboliu pushed a commit that referenced this pull request Nov 28, 2025
…ly (sonic-net#24622)

#### Why I did it
src/dhcprelay
```
* 39e28c4 - (HEAD -> master, origin/master, origin/HEAD) [dhcp4relay]: Fix swss-common references (#81) (25 hours ago) [Shivashankar C R]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants