[Mellanox] Skip the leftover hardware reboot cause in case of warm/fast reboot#78
Closed
[Mellanox] Skip the leftover hardware reboot cause in case of warm/fast reboot#78
Conversation
Signed-off-by: Kebo Liu <[email protected]>
Signed-off-by: Kebo Liu <[email protected]>
Collaborator
|
LGTM but we probably need unit test cases updated to cover the change. |
Signed-off-by: Kebo Liu <[email protected]>
stephenxs
approved these changes
Dec 30, 2022
keboliu
pushed a commit
that referenced
this pull request
Nov 8, 2023
…utomatically (sonic-net#16842) #### Why I did it src/sonic-host-services ``` * fc88254 - (HEAD -> 202305, origin/202305) Support to config fips state (#69) (#78) (16 hours ago) [xumia] ``` #### How I did it #### How to verify it #### Description for the changelog
keboliu
pushed a commit
that referenced
this pull request
Dec 22, 2025
…ly (sonic-net#24654) #### Why I did it src/sonic-stp ``` * 6be3721 - (HEAD -> master, origin/master, origin/HEAD) Correcting stp-stpmgrd IPC data structure similar to structure defined in stpmgr.h file (#80) (4 days ago) [Divya Kumaran Chandralekha] * e80c7be - [stpctl] stpctl enhancements for mstp debugging commands (#79) (5 days ago) [vganesan-nokia] * bfcb492 - [mstp] Fix for port enable handlinging and rx pkt type check (#78) (5 days ago) [vganesan-nokia] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
In case of warm/fast reboot, the hardware reboot cause will NOT be cleared because CPLD will not be touched in this flow. To not confuse the reboot cause determine logic, the leftover hardware reboot cause shall be skipped by the platform API, platform API will return the 'REBOOT_CAUSE_NON_HARDWARE' reboot cause when the last boot was warm/fast boot.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)