[201911] [Mellanox] Set psu status led to green during init stage#55
Closed
[201911] [Mellanox] Set psu status led to green during init stage#55
Conversation
Signed-off-by: Kebo Liu <kebol@nvidia.com>
keboliu
pushed a commit
that referenced
this pull request
Jun 20, 2022
[sonic-linkmgrd][202012] submodule update 3523738 Jing Zhang Sun Apr 3 20:54:40 2022 -0700 Reset link prober state when default route is back #56 8282e78 Jing Zhang Fri Apr 15 15:59:34 2022 -0700 Keep incrementing sequence number when link prober is suspended and shutdown #55 (#65) 8246eb8 Jing Zhang Thu Apr 14 18:49:36 2022 -0700 Shutdown ICMP heartbeats when default route state is missing and ToR is in auto mode #44 (#59) sign-off: Jing Zhang zhangjing@microsoft.com
keboliu
pushed a commit
that referenced
this pull request
Jan 15, 2025
…ly (sonic-net#21230) #### Why I did it src/dhcprelay ``` * b242307 - (HEAD -> master, origin/master, origin/HEAD) Revert "Fail build when test fail (#53)" (#62) (19 hours ago) [Yaqiang Zhu] * dbaee8b - Fail build when test fail (#53) (6 days ago) [Yaqiang Zhu] * ef7b972 - [Build] Update to build bookworm debian package (#55) (8 days ago) [Yaqiang Zhu] * 011066a - Add wait and check ip address check when dhcp6relay init (#52) (11 days ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog
keboliu
pushed a commit
that referenced
this pull request
Jun 6, 2025
…ly (sonic-net#22595) #### Why I did it src/sonic-stp ``` * 33314fc - (HEAD -> master, origin/master, origin/HEAD) MSTP Feature - stpsync API changes (#55) (12 days ago) [Divya Kumaran Chandralekha] ``` #### How I did it #### How to verify it #### Description for the changelog
keboliu
pushed a commit
that referenced
this pull request
Sep 18, 2025
…ically (sonic-net#23843) #### Why I did it src/sonic-dash-ha ``` * a680530 - (HEAD -> master, origin/master, origin/HEAD) Route exchange (#55) (2 days ago) [yue-fred-gao] * e205d4d - Convert Unspecified to Standby in DashHaScopeTable. (#97) (2 days ago) [dypet] * 557fe19 - Fix producer bridge CI issue (#105) (3 days ago) [yue-fred-gao] ``` #### How I did it #### How to verify it #### Description for the changelog
keboliu
pushed a commit
that referenced
this pull request
Nov 10, 2025
…sonic-net#24099) #### Why I did it src/dhcpmon ``` * 5636443 - (HEAD -> master, origin/master, origin/HEAD) Add packet length check when receiving a packet (#55) (23 hours ago) [Yanpeng Zhang] ``` #### How I did it #### How to verify it #### Description for the changelog
keboliu
pushed a commit
that referenced
this pull request
Dec 22, 2025
The following are the changes to get the modules compile:
* Update `probe` function signature in the `i2c_driver instance dropping
`i2c_device_id` parameter. This parameter is mostly unused in the probe
function, if used, can be derived from the passed client pointer.
* Remove `llseek` assignment to `no_llseek` in `file_operations`.
* Remove `I2C_CLASS_SPD` attribute added by the modules.
* Add missing import to `PMBUS` namespace.
* Update `remove` function signature in the `platform_driver` and `pci_driver`
instances, dropping return values.
* Update `i2c_mux_add_adapter` args, dropping more than 3 args, if passed.
* Fix `-Wint-conversion` errors occurring when `resource_size_t` is set to
`NULL` instead of `0`.
* Replace `strlcpy` with `strscpy`.
The following changes are done to align with trixie build (and other platforms):
* Remove `debian/compat` file.
* Update compat level to 13 and kernel version in `debian/control`.
* Update `debian/rules` to use `pybuild` for non-PDDF modules and the
conventional wheel package build for the PDDF modules. Also set shell option to
exit upon encountering error.
* Cleanup copying of wheel package in non-PDDF modules as the scripts are
installed as part of debian package.
* Make wheel package available under `build-<mod>` instead of under `modules`.
The changes are tested by building the platform packages through invoking the
below command:
`make NOBUSTER=1 NOBULLSEYE=1 NOBOOKWORM=1 target/debs/trixie/platform-modules-dx010_1.0_amd64.deb`
Additionally, with further changes to rebranding of platform (not part of this
commit, will be raised separately) and skipping inclusion of other platforms,
verified install/boot of the `sonic-broadcom.bin` on a `DS3000` unit.
platform-celestica: config and script fixes for pddf init (#55)
The following fixes applicable to platforms (ds1000, ds2000, ds3000,
ds4000/silverstone-v2) for correct pddf intialization and access of platform
devices:
* Update pddf-device json eliminating the need for additional indexing,
multiplication operations in raw ipmi get.
* The PDDF infra expects `num_components` as part of json config, update the
same.
* The ASIC PCIe firmware version uses `bcmcmd` to fetch the version. However,
when syncd is not running, the error string is reported as version, fix this
by return version as `Unknown` instead.
* The PDDF component init passes pddf_data and pddf_plugin_data parameters,
accommodate this.
* Lookup correct overridden fan names from the PDDF plugin data accommodating
fantray/psu and fan indices.
* Lookup correct overridden thermal names from the PDDF plugin data.
* Update platform specific monitoring service to start after `pddf-platform-init`
service as this service imports `sonic_platform` module.
* Update references of `/sys/class/i2c-adapter` to `/sys/bus/i2c/devices`
instead.
Tested these changes on ds1000, ds2000, ds3000 and silverstone-v2 platforms with
accessing platform commands querying PDDF components. Verified that the accesses
to the components are ok.
Co-authored-by: Ramasamy Chandramouli <rachandr@celestica.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kebo Liu kebol@nvidia.com
Why I did it
In 201911, there is no PSU status LED control from PMON, the PSU status LED could be random after boot up.
To avoid confusion, set the PSU status LED to green after PMON is initialized.
How I did it
During PSU object init, set the PSU status LED to green.
How to verify it
Install image on 201911, check the PSU status LED after PMON started, expecting green.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)