Skip to content

Platform api support rj45 test rebase#49

Closed
keboliu wants to merge 21 commits intomasterfrom
platform-api-support-RJ45-test-rebase
Closed

Platform api support rj45 test rebase#49
keboliu wants to merge 21 commits intomasterfrom
platform-api-support-RJ45-test-rebase

Conversation

@keboliu
Copy link
Copy Markdown
Owner

@keboliu keboliu commented Mar 28, 2022

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

keboliu and others added 21 commits March 28, 2022 14:18
@keboliu
change platform API to support RJ45 ports
9c63c0e 
Signed-off-by: Kebo Liu <[email protected]>
@stephenxs @keboliu
Support ONIE upgrade for SN2201
f6184d5 
Do not check ONIE version on SN2201.
In legacy switches, upgrading firmware from ONIE was supported from a certain version
while it is supported from the very beginning on SN2201.
So we do not need to check ONIE version on SN2201

Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Adjust mlnx-ssd-fw-update.sh for SN2201
5e54bc7 
Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Skip ComponentBIOS on SN2201
b35f374 
Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Support RJ45 port
936be6d 
1. A derived class representing RJ45 ports is introduced. get_presence always returns True
2. SFP error event is leveraged to represent "unknown" and "not present" states.
   By doing so, most of code change for supporting RJ45 is restricted in platform API and CLI
   xcvrd won't need to be updated for this

Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Fix error in sfp.reinit
3b1acf9 
Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Support initialization of RJ45 port status
c580810 
- Hide the logic to convert port_change to error_dict inside sfp_event
- In case there are some RJ45 ports are down (not present),
  report them as sfp_event during the first round of get_change_event
  This is because SDK/FW will never report port change occurred before init
  We must make compensation for it in platform API

Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Fix issue:
5ae0425 
- Report unknown event for RJ45 ports
- Fix syntax error

Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Add test cases for SFP event
5ee8cfd 
Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Remove unused local variables
e85c952 
Signed-off-by: Stephen Sun <[email protected]>
@keboliu
recover hwsku.json
7856c2b 
Signed-off-by: Kebo Liu <[email protected]>
@stephenxs @keboliu
Fix comments
6497691 
Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Fix review comments: do a mock i unit test and make extract_RJ45_port…
935c4a0 
…s_index_return []

Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Fix log issue
3a846c1 
Signed-off-by: Stephen Sun <[email protected]>
@keboliu
simplify json file parsing code logic, remove redundant spaces from s…
7212452 
…sd fw update scripts

Signed-off-by: Kebo Liu <[email protected]>
@stephenxs @keboliu
Support BIOS version
fbcc954 
Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Update platform_component.json
dd6b89d 
Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Fix sfp review comments
1710d82 
Signed-off-by: Stephen Sun <[email protected]>
@stephenxs @keboliu
Fix comments in ComponentBIOS
efd48b7 
Signed-off-by: Stephen Sun <[email protected]>
@keboliu
remove unnecessary line
7323c88
@keboliu
refactor sfp.py based on new API
0122cf4
stephenxs
stephenxs approved these changes Mar 28, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stephenxs stephenxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comments.

Comment thread platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py

return eeprom_raw is not None

Copy link
Copy Markdown
Collaborator

@stephenxs stephenxs Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove space

@keboliu keboliu closed this Mar 30, 2022
keboliu pushed a commit that referenced this pull request May 6, 2022
@liushilongbuaa
[submodule] Update submodule for sonic-mgmt-common (sonic-net#10664)
672db8d 
submodule update, includes:

ec32690 CVE-2020-25614: Update xmlquery, jsonquery and xpath packages. (#58)
5156527 Showtech sonic mgmt framework: Add Management Framework functionality for "show tech-support" (#49)
keboliu pushed a commit that referenced this pull request Jun 20, 2022
@zjswhhh
[202012][sonic-linkmgrd] Submodule Update (sonic-net#10345)
9fd75ff 
[202012][sonic-linkmgrd]Submodule update

8507629 Jing Zhang      Mon Apr 4 10:25:22 2022 -0700   Lower unsolicited MUX state change notification log level to WARNING #57
17d217d Longxiang Lyu   Mon Mar 21 12:15:19 2022 +0800  Enhance clang format (#46)
c72fa2a Jing Zhang      Fri Apr 1 12:23:29 2022 -0700   Disable the feature that decreases link probe interval for measuring switch overhead #49 (#54)
256b01b Jing Zhang      Thu Mar 31 16:20:00 2022 -0700  Update link prober metrics posting logics #50 #53
dfd48d0 Jing Zhang      Wed Mar 23 16:27:45 2022 -0700  Decrease link probing interval after switchover to better determine the overhead of a toggle #43 (#48)

sign-off: Jing Zhang [email protected]
keboliu pushed a commit that referenced this pull request May 31, 2023
@mssonicbld
[submodule] Update submodule wpasupplicant/sonic-wpa-supplicant to th…
b8bf426 
…e latest HEAD automatically (sonic-net#15016)

src/wpasupplicant/sonic-wpa-supplicant

* a24412c25 - (HEAD -> 202205, origin/master, origin/HEAD, origin/202211, origin/202205, master) [mka]: Fix unexpected cleanup (#73) (8 days ago) [Ze Gan]
* 26d1da0bc - [mka]: Fix re-establishment by reset MI (#72) (8 days ago) [Ze Gan]
* f07e0a097 - [azp]: Update build pipeline to build for Bullseye (#70) (4 weeks ago) [Ze Gan]
*   2c69e2cda - Use github code scanning instead of LGTM (#69) (6 months ago) [Liu Shilong]
|\  
| * 23abb04e5 - fix (6 months ago) [shilongliu]
| * f34d68fe6 - libdbus-1-dev (6 months ago) [shilongliu]
| * dc2dd881e - add dbus (6 months ago) [shilongliu]
| * 5de037661 - use swsscommon packages (6 months ago) [shilongliu]
| * 32c5a2729 - Use github code scanning instead of LGTM (6 months ago) [shilongliu]
|/  
* aa731b96f - [azp]: Install libyang in azure pipeline (#68) (8 months ago) [Hua Liu]
* 71b635d74 - Revert "[Azp]: Upgrade Azp to bullseye (#49)" (#66) (9 months ago) [Ze Gan]
* 7aa4e6fa4 - Adding Microsoft SECURITY.MD (#58) (9 months ago) [microsoft-github-policy-service[bot]]
@keboliu keboliu deleted the platform-api-support-RJ45-test-rebase branch June 14, 2023 10:02
keboliu pushed a commit that referenced this pull request Jun 27, 2023
@mssonicbld
[submodule] Update submodule sonic-host-services to the latest HEAD a…
2f4cd3a 
…utomatically (sonic-net#15591)

#### Why I did it
src/sonic-host-services
```
* eab4a9e - (HEAD -> master, origin/master, origin/HEAD) [hostcfgd][dns] Subscribe to DNS_NAMESERVER table to react to static DNS configuration changes. (#49) (2 days ago) [Oleksandr Ivantsiv]
```
#### How I did it
#### How to verify it
#### Description for the changelog
keboliu pushed a commit that referenced this pull request Jun 5, 2024
@mssonicbld
[submodule] Update submodule dhcprelay to the latest HEAD automatical…
4280e77 
…ly (sonic-net#19156)

#### Why I did it
src/dhcprelay
```
* c605cd4 - (HEAD -> 202311, origin/202311) [202311] Backport commit from master into 202311 (#49) (2 hours ago) [Yaqiang Zhu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
keboliu pushed a commit that referenced this pull request Mar 26, 2025
@mssonicbld
[submodule] Update submodule sonic-stp to the latest HEAD automatical…
bf6811d 
…ly (sonic-net#21970)

#### Why I did it
src/sonic-stp
```
* f3dfb2c - (HEAD -> master, origin/master, origin/HEAD) Mstp Feature - Adding library and DB management APIs (#50) (14 hours ago) [Divya Kumaran Chandralekha]
* 38ac0f1 - MSTP header files (#49) (23 hours ago) [Divya Kumaran Chandralekha]
```
#### How I did it
#### How to verify it
#### Description for the changelog
keboliu pushed a commit that referenced this pull request Sep 18, 2025
@mssonicbld
[submodule] Update submodule dhcpmon to the latest HEAD automatically (…
5f92624 
…sonic-net#23834)

#### Why I did it
src/dhcpmon
```
* f08f25e - (HEAD -> master, origin/master, origin/HEAD) Optimize clear counter logic (#49) (3 days ago) [Yaqiang Zhu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenxs stephenxs stephenxs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keboliu @stephenxs