Enhance Mellanox Platform API implementation to support SN2201 and RJ45 port#41
Closed
Enhance Mellanox Platform API implementation to support SN2201 and RJ45 port#41
Conversation
keboliu
changed the title
liat-grozovik
suggested changes
Feb 21, 2022
platform/mellanox/mlnx-platform-api/sonic_platform/component.py
Outdated
Show resolved
Hide resolved
platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py
Outdated
Show resolved
Hide resolved
|
I believe other systems does not have that as well
So should we add more systems?
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Stephen Sun ***@***.***>
Sent: Monday, February 21, 2022 12:09:32 PM
To: keboliu/sonic-buildimage ***@***.***>
Cc: Liat Grozovik ***@***.***>; Comment ***@***.***>
Subject: Re: [keboliu/sonic-buildimage] Enhance Mellanox Platform API implementation to support SN2201 and RJ45 port (PR #41)
@stephenxs commented on this pull request.
________________________________
In platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py<#41 (comment)>:
@@ -1242,7 +1246,10 @@ def get_transceiver_threshold_info(self):
]
transceiver_dom_threshold_info_dict = dict.fromkeys(dom_info_dict_keys, 'N/A')
- if self.sfp_type == OSFP_TYPE:
+ if not self.dom_supported:
+ return transceiver_dom_threshold_info_dict
Now sure whether I understood the question correctly.
if dom is not supported, all fields should be N/A. this is also what we did for SFP ports.
—
Reply to this email directly, view it on GitHub<#41 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTABA64USJJZPUK32NE2PLU4IFNZANCNFSM5OXGYQTA>.
Triage notifications on the go with GitHub Mobile for iOS<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cliatg%40nvidia.com%7Ca2daec3a10d346073ffc08d9f5224213%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637810349762421202%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=BHgAMruYrqISK5qiJkz0dgkNaM0KjzHjqtylQSK1lrM%3D&reserved=0> or Android<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cliatg%40nvidia.com%7Ca2daec3a10d346073ffc08d9f5224213%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637810349762421202%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Fk50CmHpXPA11JoADOgk5lTNGf%2BxVvS2AjM6oeVlo9k%3D&reserved=0>.
You are receiving this because you commented.Message ID: ***@***.***>
|
This was referenced Feb 22, 2022
Merged
Junchao-Mellanox
approved these changes
Mar 14, 2022
keboliu
pushed a commit
that referenced
this pull request
Mar 21, 2022
f00efef Longxiang Lyu Wed Mar 16 09:12:46 2022 +0800 Add a command line option to store logs into a separate file (#41) ff2e67d Longxiang Lyu Tue Mar 15 09:10:59 2022 +0800 Add default port cable type (#39) ebbb4d8 Jing Zhang Mon Mar 14 15:41:11 2022 -0700 Prevent switching MUX to "Unknown" (#36) c779b8f Longxiang Lyu Thu Mar 10 21:35:11 2022 +0800 [nonfunctional] Use LinkProberStateMachineBase (#38) b9fedd0 Longxiang Lyu Wed Mar 9 13:03:58 2022 +0800 [NONFUNCTIONAL] Add LinkProberStateMachineBase (#37) bedd42b Longxiang Lyu Wed Mar 9 10:03:00 2022 +0800 Add .clang-format file to format code (#28) 9fe4fc6 Guohan Lu Thu Mar 3 17:51:43 2022 -0800 [doc]: add lgtm badge in README.md c1249d9 Longxiang Lyu Wed Mar 2 18:05:18 2022 +0800 Enable lgtm (#33) b8514c6 Longxiang Lyu Wed Mar 2 13:34:39 2022 +0800 Collect port cable type to use corresponding state machine (#31) 9b59ef9 Longxiang Lyu Wed Mar 2 07:19:33 2022 +0800 Improve make clean (#32)
keboliu
force-pushed
the
platform-api-support-RJ45
branch
from
d0ce777 to
09dcfa9
Compare
Signed-off-by: Kebo Liu <[email protected]>
Do not check ONIE version on SN2201. In legacy switches, upgrading firmware from ONIE was supported from a certain version while it is supported from the very beginning on SN2201. So we do not need to check ONIE version on SN2201 Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
1. A derived class representing RJ45 ports is introduced. get_presence always returns True 2. SFP error event is leveraged to represent "unknown" and "not present" states. By doing so, most of code change for supporting RJ45 is restricted in platform API and CLI xcvrd won't need to be updated for this Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
- Hide the logic to convert port_change to error_dict inside sfp_event - In case there are some RJ45 ports are down (not present), report them as sfp_event during the first round of get_change_event This is because SDK/FW will never report port change occurred before init We must make compensation for it in platform API Signed-off-by: Stephen Sun <[email protected]>
- Report unknown event for RJ45 ports - Fix syntax error Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Kebo Liu <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
…s_index_return [] Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
…sd fw update scripts Signed-off-by: Kebo Liu <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
keboliu
force-pushed
the
platform-api-support-RJ45
branch
from
09dcfa9 to
079ca89
Compare
keboliu
pushed a commit
that referenced
this pull request
Dec 2, 2024
…ly (sonic-net#20959) #### Why I did it src/sonic-stp ``` * ea85d65 - (HEAD -> master, origin/master, origin/HEAD) [ci] Add arm64 build on PR validation. (#41) (20 hours ago) [Xin Wang] * 6cdf964 - fix (25 hours ago) [Shilong Liu] * 40cd2d5 - fix (2 days ago) [Shilong Liu] * 0bfbed4 - makefile (2 days ago) [Shilong Liu] * 837b0ce - makefile (2 days ago) [Shilong Liu] * 0ef306e - fix (2 days ago) [Shilong Liu] * 859374c - fix (2 days ago) [Shilong Liu] * 7d65161 - fix (2 days ago) [Shilong Liu] * 6580a62 - fix (2 days ago) [Shilong Liu] * 017f2a9 - fix (2 days ago) [Shilong Liu] * a26b6c2 - [ci] Try building on arm agent. (2 days ago) [Shilong Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
keboliu
pushed a commit
that referenced
this pull request
Aug 13, 2025
…tically (sonic-net#23101) #### Why I did it src/sonic-dash-api ``` * 38853ef - (HEAD -> master, origin/master, origin/HEAD) Use ValueOrRange for trusted_vni fields (#41) (2 days ago) [Lawrence Lee] * 5daac7d - Add outbound port map proto definitions (#40) (2 days ago) [Lawrence Lee] ``` #### How I did it #### How to verify it #### Description for the changelog
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 14, 2026
fbccffa (HEAD -> main, origin/main, origin/HEAD) Add function to validate and regenerate ONIE EEPROM cahce file if needed 72bf0c6 [H4-32D][H5-32D][H5-64D][H5-64O] Fix GPIO base change on Trixie (#41) f3f90e3 Increase frequency of fstrim from weekly to daily for chassis 1b7645f [X4] Add support for IXR7250 X4 platform 2348e9b [H6-64] support kernel 6.12.x 3b36679 [H6-64] Add support for Nokia H6-64 16e8635 Modify hw-mnangement-generate-dump to include qfpga info log 23d69af Add mechanism to LC to send eeprom info to CHASSIS_STATE_DB 5f18eab [H5-64O]Update thermal algorithm according to HW spec V04 65293de [H5-64D][H5-64O]Update thermal algorithm 18686fe [H4-32D][H5-32D][H5-64D][H5-64O]Fix emc2305 driver fan speed initialization issue 6412f56 cpuctl i2c delay optic 5199ecf cpuctl i2c delay optic Signed-off-by: mlok <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Support SN2201 SSD FW upgrade in platform API
Support SN2201 ONIE upgrade in platform API
Support RJ45 port in platform API
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)