Skip to content

Use proper value for GOPRIVATE in sync-tags #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

Use proper value for GOPRIVATE in sync-tags #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cmd/sync-tags/gomod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ func updateGomodWithTaggedDependencies(searchTag string, depsRepo []string, semv
return changed, err
}

fmt.Println("Found the following dependencies to update:", depPackages)

for _, dep := range depsRepo {
depPath := filepath.Join("..", dep)
dr, err := gogit.PlainOpen(depPath)
Expand Down Expand Up @@ -185,14 +183,18 @@ func updateGomodWithTaggedDependencies(searchTag string, depsRepo []string, semv
}

// depImportPaths returns a comma separated string with each dependencies' import path.
// Eg. "k8s.io/api,k8s.io/apimachinery,k8s.io/client-go".
// Eg. "github.com/kcp-dev/apimachinery,github.com/kcp-dev/client-go".
func depsImportPaths(depsRepo []string) (string, error) {
dir, err := os.Getwd()
if err != nil {
return "", fmt.Errorf("unable to get current working directory: %w", err)
}
d := strings.Split(dir, "/")
basePackage := d[len(d)-2]
server := d[len(d)-3]
if server != "src" {
basePackage = fmt.Sprintf("%s/%s", server, basePackage)
}

depImportPathList := []string{}
for _, dep := range depsRepo {
Expand Down