feat: support login with plainhttp#638
Merged
Merged
Conversation
Signed-off-by: Lan Liang <gcslyp@gmail.com>
Signed-off-by: Lan Liang <gcslyp@gmail.com>
Pull Request Test Coverage Report for Build 15045578640Details
💛 - Coveralls |
liangyuanpeng
force-pushed
the
feat_login_http
branch
2 times, most recently
from
e84ccbc to
d4cf065
Compare
change test registry port from 5001 to 5002 Signed-off-by: Lan <gcslyp@gmail.com>
liangyuanpeng
force-pushed
the
feat_login_http
branch
from
d4cf065 to
bbd46d6
Compare
liangyuanpeng
commented
May 15, 2025
| } | ||
| }() | ||
|
|
||
| os.Setenv("OCI_REG_PLAIN_HTTP", "ON") |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if there is a better way
Contributor
Author
|
This PR requires the main review file: pkg/client/login.go
pkg/client/login_test.go
scripts/push_pkg.sh
scripts/reg.sh |
Contributor
Author
zong-zhe
approved these changes
May 22, 2025
zong-zhe
left a comment
zong-zhe
left a comment
Contributor
There was a problem hiding this comment.
Excellent work! 👍 LGTM!
fhopfensperger
pushed a commit
to fhopfensperger/kcl-lang-kpm
that referenced
this pull request
Jun 3, 2025
* feat: support login with plainhttp Signed-off-by: Lan Liang <gcslyp@gmail.com> * fix: update argo-cd-order to 0.2.1 Signed-off-by: Lan Liang <gcslyp@gmail.com> * feat: add test for login with oci change test registry port from 5001 to 5002 Signed-off-by: Lan <gcslyp@gmail.com> --------- Signed-off-by: Lan Liang <gcslyp@gmail.com> Signed-off-by: Lan <gcslyp@gmail.com>
fhopfensperger
pushed a commit
to fhopfensperger/kcl-lang-kpm
that referenced
this pull request
Jun 3, 2025
* feat: support login with plainhttp Signed-off-by: Lan Liang <gcslyp@gmail.com> * fix: update argo-cd-order to 0.2.1 Signed-off-by: Lan Liang <gcslyp@gmail.com> * feat: add test for login with oci change test registry port from 5001 to 5002 Signed-off-by: Lan <gcslyp@gmail.com> --------- Signed-off-by: Lan Liang <gcslyp@gmail.com> Signed-off-by: Lan <gcslyp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #636
changes
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: