Skip to content

add retryWrites#395

Merged
Xiangs18 merged 3 commits intodevelopfrom
dev-add_retryWrites
Aug 27, 2024
Merged

add retryWrites#395
Xiangs18 merged 3 commits intodevelopfrom
dev-add_retryWrites

Conversation

@Xiangs18
Copy link
Copy Markdown
Contributor

No description provided.

@Xiangs18 Xiangs18 requested a review from MrCreosote August 27, 2024 22:25
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.11%. Comparing base (5316580) to head (7ab4105).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #395   +/-   ##
==========================================
  Coverage      94.10%   94.11%           
- Complexity      1595     1596    +1     
==========================================
  Files            102      102           
  Lines           4735     4739    +4     
  Branches         828      828           
==========================================
+ Hits            4456     4460    +4     
  Misses           265      265           
  Partials          14       14           

Copy link
Copy Markdown
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just a minor docs improvement

Comment on lines +433 to +434
/** Get the retryWrites.
* @return the retryWrites.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Get the retryWrites.
* @return the retryWrites.
/** Get whether the MongoDB retryWrites parameter should be set.
* @return True to set the retryWrites parameter when connecting to MongoDB, false otherwise.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Xiangs18 Xiangs18 merged commit ff5bc82 into develop Aug 27, 2024
@Xiangs18 Xiangs18 deleted the dev-add_retryWrites branch August 27, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants