Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #394 +/- ##
=============================================
+ Coverage 94.08% 94.10% +0.02%
- Complexity 1594 1595 +1
=============================================
Files 102 102
Lines 4734 4735 +1
Branches 827 828 +1
=============================================
+ Hits 4454 4456 +2
+ Misses 266 265 -1
Partials 14 14 |
MrCreosote
reviewed
Aug 26, 2024
Member
MrCreosote
left a comment
MrCreosote
left a comment
There was a problem hiding this comment.
Looks pretty good, just needs retryWrites and I have 1 question
| final Pattern errorPattern = Pattern.compile( | ||
| "Failed to create index: Write failed with error code 11000 and error message " + | ||
| "'(exception: )?E11000 duplicate key error (index|collection): " + | ||
| "'(exception: )?(.*)E11000 duplicate key error (index|collection): " + |
Contributor
Author
There was a problem hiding this comment.
Comment on lines
+110
to
+111
| final MongoClientSettings.Builder mongoBuilder = MongoClientSettings.builder().applyToClusterSettings( | ||
| builder -> builder.hosts(Arrays.asList(new ServerAddress(c.getMongoHost())))); |
Member
There was a problem hiding this comment.
You're going to need the retryWrites parameter as well
Contributor
Author
There was a problem hiding this comment.
Adding the retryWrites parameter will be included in the next PR.
MrCreosote
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.